Issue 87245 - Letter wizard no longer works on DEV300_m3
Summary: Letter wizard no longer works on DEV300_m3
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m3
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: h.ilter
QA Contact: issues@framework
URL:
Keywords:
: 87640 (view as issue list)
Depends on:
Blocks:
 
Reported: 2008-03-19 13:31 UTC by eric.bachard
Modified: 2008-05-20 17:37 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
a fix for letter wizard not working in DEV300_mx (x > 1 ) (862 bytes, patch)
2008-03-19 14:38 UTC, eric.bachard 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description eric.bachard 2008-03-19 13:31:28 UTC 
No letter wizard since DEV300_m3

The cause is explained ( thanks Caolan ) and I'll provide a patch and more
information asap
Comment 1 eric.bachard 2008-03-19 13:32:33 UTC 
+ cmc on CC
Comment 2 eric.bachard 2008-03-19 14:35:17 UTC 
The issue was caused by new entries added in svtools/inc/svtools/svtools.hrc, and the entry for letter 
wizard (in wizards/com/sun/star/wizards/letter/LocaleCodes.java )  was not modified accordingly ( +1 
for the slot number not incremented)

STR_ARR_SVT_LANGUAGE_TABLE from svtools/source/misc/langtab.src expects 12300, while 16299 was 
used.

a patch will be attached
Comment 3 eric.bachard 2008-03-19 14:36:06 UTC 
@cmc : I don't see the change with cvl log svtools.harc ? You explained me it was between m1 and m2, 
right ?
Comment 4 eric.bachard 2008-03-19 14:36:18 UTC 
@cmc : I don't see the change with cvl log svtools.hrc ? You explained me it was between m1 and m2, 
right ?
Comment 5 eric.bachard 2008-03-19 14:38:36 UTC 
Created attachment 52213 [details]
a fix for letter wizard not working in DEV300_mx  (x > 1 )
Comment 6 eric.bachard 2008-03-19 14:39:27 UTC 
Set target +  changed for correct issue type
Comment 7 caolanm 2008-03-19 14:59:49 UTC 
cvs diff -u -rDEV300_m1 DEV300_m2 inc/svtools/svtools.hrc 
and
cvs diff -u -rDEV300_m1 DEV300_m2 com/sun/star/wizards/letter/LocaleCodes.java 

I suggest when fixing this to move the resources in question to maybe the top of
svtools.hrc and give them the lowest values in svtools, that'll make them much
less likely to need to change again
Comment 8 Mechtilde 2008-03-19 15:02:19 UTC 
why target 3.1 and not 3.0

A major release without letter wizard => very bad
Comment 9 eric.bachard 2008-03-21 08:12:07 UTC 
Issue fixed in aquavcl06
Comment 10 mikhail.voytenko 2008-04-01 16:38:54 UTC 
*** Issue 87640 has been marked as a duplicate of this issue. ***
Comment 11 philipp.lohmann 2008-04-01 20:16:39 UTC 
please verify in CWS aquavcl06
Comment 12 h.ilter 2008-04-03 13:14:16 UTC 
Verified with cws aquavcl06 = ok
Comment 13 h.ilter 2008-04-03 13:15:53 UTC 
Set to Verified
Comment 14 andreschnabel 2008-05-20 17:37:14 UTC 
ok in OOo 3.0 beta ->closing