Created attachment 52407 [details]
Serbian locale (sr_*, sh_*) fixes

You see me a bit confused about the currency changes. For RSD you change the
CurrencySymbol from 'Din' to 'RSD'. Why? For CSD you change CurrencySymbol from
'Din' to 'CSD'. Why? In daily life, do you really write CSD or RSD instead of Din?

With

     <Currency default="false" usedInCompatibleFormatCodes="true">
       <CurrencyID>CSD</CurrencyID>
-      <CurrencySymbol>Din</CurrencySymbol>
+      <CurrencySymbol>CSD</CurrencySymbol>

you also said to change the code used in format codes from 'Din' to 'CSD', but
in the format codes you change it from 'Din' to 'RSD' by

-  <LC_FORMAT ref="sr_RS" replaceFrom="[CURRENCY]" replaceTo="[$Din-881A]"/>
+  <LC_FORMAT ref="sr_RS" replaceFrom="[CURRENCY]" replaceTo="[$RSD-881A]"/>

Note that for programmatic reasons the CurrencySymbol can't be simply changed
because you won't be able to display documents correctly that used the old
symbol. Instead, a new Currency element has to be created and the old Currency
element needs a legacyOnly="true" attribute.


The addition of

+      <CurrencyID>DIN</CurrencyID>
+      <CurrencySymbol>din.</CurrencySymbol>
+      <BankSymbol>RSD</BankSymbol>
+      <CurrencyName>Srpski dinar</CurrencyName>

introduces a duplicate of

+      <CurrencyID>RSD</CurrencyID>
+      <CurrencySymbol>RSD</CurrencySymbol>
+      <BankSymbol>RSD</BankSymbol>
+      <CurrencyName>Srpski dinar</CurrencyName>

just that CurrencyID differs. Why? Note that CurrencyID and BankSymbol currently
should be identical and be ISO 4217 codes, but there is no DIN code.

"din." (short for dinars), not "Din", in unofficial currency symbol, wich is no
longer used in official documents. If you want to write Invoice or something,
you can only use RSD, not "din.".

Some people still want to use "din." for their ***personal*** documents, so we
have to keep that one too, that is why duplication. I can change code to Din
("din." as symbol), for compatibility reasons, but note that there was never
bank code DIN.

Default currency symbol should be RSD (РСД in Cyrillic), bank code RSD. Legacy
code is CSD (used during state union Serbia & Montenegro) but sometime there is
a need to use this in new documents too. Even older code is YUD (1993-2000),
same about usage apply here too.

What about sr_YU and sh_YU locales, do we need those for compatibility or not?

> "din." (short for dinars), not "Din", in unofficial currency symbol,
> wich is no longer used in official documents. If you want to write
> Invoice or something, you can only use RSD, not "din.".

If RSD is the official currency symbol we do need that. However,
http://en.wikipedia.org/wiki/Serbian_dinar does not say so, it has
'din.' in Latin and Cyrillic script, and I didn't find anything related
at http://www.nbs.yu/internet/english/35/index.html

> Some people still want to use "din." for their ***personal*** documents,
> so we have to keep that one too, that is why duplication. I can change
> code to Din ("din." as symbol), for compatibility reasons, but note that
> there was never bank code DIN.

We can not have two currencies with the same BankSymbol listed. As said,
we can add a duplicate with a different CurrencySymbol if the
legacyOnly="true" attribute is added to be able to display already
existing documents that used the old symbol, but the entry wouldn't be
listed as available number formats if a document doesn't use it. This is
on purpose. Note that in a stored document only the ISO 4217 code is
stored, taken from BankSymbol. When loading we do a match against the
symbol of the display string to determine the number format used, if it
is BankSymbol or CurrencySymbol. If there is no match with the current
definition we match against legacyOnly entries.


> Default currency symbol should be RSD (РСД in Cyrillic), bank code RSD.
> Legacy code is CSD (used during state union Serbia & Montenegro) but
> sometime there is a need to use this in new documents too.

Having one CSD and one RSD entry at the same time is no problem.

> Even older
> code is YUD (1993-2000), same about usage apply here too.

We can add that as well if it is needed, no problem. Altogether it just
makes the list of available currency formats in the dialog quite long.


Regarding the change of  replaceTo="[$Din-881A]"  to  replaceTo="[$RSD-881A]"
The symbol used there has to match the CurrencySymbol of the Currency
element that has the usedInCompatibleFormatCodes="true" attribute. Note
that to display the number formats in the dialog and to derive the
default currency format for a locale the symbol is exchanged with the
one from the default="true" Currency element, so it doesn't matter if
there is an old symbol listed in format codes, it just has to match the
element flagged as usedInCompatibleFormatCodes.


> What about sr_YU and sh_YU locales, do we need those for compatibility
> or not?

Yes, we do, to be able to properly load documents that used those
locales in the past. See also
http://l10n.openoffice.org/servlets/ReadMsg?list=features&msgNo=122

Any thoughts about the comments I made on the currency issues in #desc5?

Official symbol is „RSD“ (and „РСД“ for Serbian Cyrillic) and speaking with
several users this is what it should be.

I would like to support legacy „din.“ and „дин.“ too (note the obligatory
tailing dot), but there is no currency code I can use. So what can I do about this?

Anyway, no matter what, „RSD“ and „РСД“ should be used in locale definition.

Reassigning to spare time account.

Overlooked that this issue depends on the numbering provider of issue 86142 that
is targeted to 3.1, adding dependency and retargeting to same target.

Note to myself: remove/undo/resolve merge conflict

-    <Collator default="true" unoid="alphanumeric" />
+    <Collator default="true" unoid="charset" />

from the patch as that would clash with the change from issue 86765.

In cws locdat30:

i18npool/source/localedata/data/sh_RS.xml  1.2.44.2
i18npool/source/localedata/data/sr_RS.xml  1.2.44.1

I sorted this out. Actually the used symbol is stored in file and upon load in
Calc matched against known currency entries (I mixed that up earlier, sorry for
confusion). Added entries with symbols RSD (default), din. and CSD, and made Din
legacyOnly for existing documents using it. I did not add YUM, as that would
only duplicate all 'din.' entries in the list box, plus 2 '[$YUM]' entries that
could easily be created by the user if really needed. I also did not touch the
*_YU locales since those should be used only to load existing documents for the
"Serbia and Montenegro" locale, which didn't have RSD then.

@goranrakic: For numbering and outline numbering please create a patch that
modifies only those and attach it to issue 86142 so we have that all in one place.

Thanks
  Eike

Created attachment 54490 [details]
The resulting diff of the changes.

Reassigning to QA for verification.

verified in internal build cws_locdat30

This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues