Issue 87822 - patches from the ooo-hebrew version
Summary: patches from the ooo-hebrew version
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 2.3.1
Hardware: All All
: P3 Trivial with 1 vote (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
Depends on:
Reported: 2008-04-03 14:59 UTC by alexbodn1
Modified: 2017-05-20 10:44 UTC (History)
12 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

diffs to the source files in ooo to fix hebrew and right to left issues (263.70 KB, application/x-tar-gz)
2008-04-03 15:24 UTC, alexbodn1
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description alexbodn1 2008-04-03 14:59:42 UTC
since the ooo-hebrew project sadly announced their activity recession, i decided
to do my best to ensure their work will not be lost.

i have no specific involvement with programming ooo, but i'm grateful to all the
project providers worldwide, since my wife and children use it.

after talking on ooo-dev irc with rene and pavel janik, i have run cvs diff -u
on the entire source directory i've downloaded from the israeli developers, tkos
and filtered out non necessary files, and files lgpl uncompatible.

the only non lgpl files i found are gpl, and may be found on any linux platform
at least.
Comment 1 alexbodn1 2008-04-03 15:24:37 UTC
Created attachment 52502 [details]
diffs to the source files in ooo to fix hebrew and right to left issues
Comment 2 rene 2008-04-04 21:36:45 UTC
the diffs to desktop, officecfg and solenv look like harcoded for ooo-hebrew
(hardcoding he/he-IL locale stuff), should not be merged.

the diffs in postprocess and canvas: I don't know what this is for, looks like
some Windows stuff...

The scp2 hunk shouldn't be needed for us either. same as svx/source and svx/res.

mh: can you find someone inside Sun who looks over the rest?
(sc/, sw/, svtools, svx without the above, wizards)
Comment 3 Martin Hollmichel 2008-04-07 14:28:58 UTC
change component since this is code.
Comment 4 stefan.baltzer 2008-04-07 14:36:38 UTC
Put myself and MBA on c/c.
Comment 5 stefan.baltzer 2008-04-07 14:52:06 UTC
SBA: I'd like to ad some QA comments at this state of the issue:
(1) Integrating "a bunch on patches at once" is far too dangerous If we do not
know what they do.
(2) "Hard-coded for Hebrew" (see renes comment) This can make sense and can be
dangerous, needs code review at least)
(3) "Causing no damage" is NOT "enough" to get code in "because it is there".
"No regressions" is an expected attribute of all code changes that gets in "for
a specified good".

"Adressing RTL issues" is nice. But we must know what each change DOES.
Otherwise we do not know what we get thus should not do it. There are SEVERAL
modules affected, so we need code reviews (at least) by a specialist of each

Maybe these patches should get inegrated seperately (module by module) and by
several issues.
Comment 6 thomas.lange 2008-11-07 13:08:42 UTC
Adding myself to CC list.
Comment 7 Rob Weir 2013-03-11 15:02:25 UTC
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:


Comment 8 kaplanlior 2013-03-12 11:34:49 UTC
I think that after five years the patches are waiting for review, we can't close this bug and ignore them. Most problems still remains valid.
Comment 9 Kay 2015-01-18 21:07:27 UTC
alexbodn1: Can you re-review your changes with respect to the current trunk?

I'm not sure some of them can be applied now without breaking other elements.

We will also try to identify other testers for this.

Thanks for your help and time with these changes.
Comment 10 Marcus 2017-05-20 10:44:11 UTC
Reset the assignee to the default "".