Issue 88067 - configure.in out of sync wrt ENABLE_MINIMIZER default
Summary: configure.in out of sync wrt ENABLE_MINIMIZER default
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: configure (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kurt.zenker
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-08 22:06 UTC by rene
Modified: 2008-04-10 09:57 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description rene 2008-04-08 22:06:36 UTC 
Hi,

This commit

--- snip --
User: vg
Date: 2008-04-08 20:43:54+0000
Modified:
   tools/solenv/config/sdev300.ini

Log:
 #i10000# ENABLE_MINIMIZER missing

File Changes:

Directory: /tools/solenv/config/
================================

File [changed]: sdev300.ini
Url:
http://tools.openoffice.org/source/browse/tools/solenv/config/sdev300.ini?r1=1.1
4&r2=1.15
Delta lines:  +1 -0
-------------------
--- sdev300.ini 2008-04-08 15:02:22+0000        1.14
+++ sdev300.ini 2008-04-08 20:43:51+0000        1.15
@@ -103,6 +103,7 @@
             ENABLE_GNOMEVFS TRUE
                        ENABLE_VBA YES
                        ENABLE_REPORTDESIGN YES
+                       ENABLE_MINIMIZER YES
                        ENABLE_MEDIAWIKI YES
                        NEW_JAR_PACK TRUE
                        PCLEAN_PATH xxx
--- snip ---
without *ANY* corresponding fix to configure[.in] from you makes configure[.in]
regarding enabling/disabling out of sync with your env. But I *DO* want to keep
them in sync. Every change in those defaults should be reflected in
configure.in, too.

Please fix.
Comment 1 vg 2008-04-09 13:54:43 UTC 
reassign
Comment 2 kurt.zenker 2008-04-09 14:17:19 UTC 
As far as I can see there is already a section for ENABLE_MINIMIZER in
configure.in and that was missing in sdev300.ini, isn't it?

---
AC_MSG_CHECKING([whether to build the Presentation Minimizer extension])
if test -n "$enable_minimizer" -a "$enable_minimizer" != "no"; then
   AC_MSG_RESULT([yes])
   ENABLE_MINIMIZER=YES
else
   AC_MSG_RESULT([no])
   ENABLE_MINIMIZER=NO
fi
AC_SUBST(ENABLE_MINIMIZER)
Comment 3 rene 2008-04-09 14:40:30 UTC 
kz: yes, there is already a section about the minimier. What does that have to
to with this issue?

This issue ia about that the check was done when the minimizer was not enabled
per default for Sun so configure defaulted to disable it, too.

Now, with vgs change, Sun setting changed, and configure should be adapted.
Comment 4 kurt.zenker 2008-04-09 17:48:47 UTC 
I fixed it as masterfix. Could you check it, please?
Comment 5 kurt.zenker 2008-04-09 17:51:24 UTC 
by default it should also be ENABLE_MINIMIZER=YES in configure now.
Comment 6 pavel 2008-04-10 09:57:33 UTC 
It is OK, closing.