Issue 88291 - OOo locks source file of linked images
Summary: OOo locks source file of linked images
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: OOo 2.4.0
Hardware: All All
: P3 Trivial with 1 vote (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2008-04-15 08:05 UTC by vitriol
Modified: 2013-08-07 14:43 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description vitriol 2008-04-15 08:05:51 UTC 
- Open Writer, and add a linked image (Insert > Picture > From file..., Link
option checked).
- Save and close the document.
- Reopen the document, and try to rename the linked image from Explorer.
- It is not possible, because the image is locked by soffice.bin process.

It seems that doesn't happen in earlier versions.

Thank you
Comment 1 mike_hall 2008-04-15 11:45:09 UTC 
Yes, it works as described. If this is a change, it seems to be what should
happen. Don't believe it's a bug. Objects used in open documents should be locked.
Comment 2 bonmario 2008-04-15 12:24:45 UTC 
This change have been introduced with version 2.4.
With 2.1, 2.2, 2.3 the linked images wasn't locked from the document.
Now if i want to replace the image, i can't before that all the users that have
opened the document exit from it.
Comment 3 michael.ruess 2008-04-16 09:44:03 UTC 
I cannot believe, that the behavior is desired / designed. At least in older
builds it was not the case and also in OO Draw it is not the case. The sense of
linked graphics is to have a source file and to make changes to the source file
- and how to change if it is locked ???
Comment 4 michael.ruess 2008-04-16 09:49:04 UTC 
MRU->OD: right after inserting the linked picture into document, source file is
not already locked. Save the document and reopen -> see that the source file is
locked now. Was not the case in OO 2.3.1.
Comment 5 Oliver-Rainer Wittmann 2008-04-16 12:35:46 UTC 
Further investigation with TKR is needed
Comment 6 Oliver-Rainer Wittmann 2008-04-18 11:29:32 UTC 
issue accepted.

Investigation with TKR reveals that an internally used input stream of the image
file is not closed after its content is read.
Comment 7 Oliver-Rainer Wittmann 2008-06-19 08:31:34 UTC 
fixed in cws sw30bf06 - changed files:
/sw/source/core/graphic/ndgrf.cxx, 1.45.86.1
/sfx2/inc/sfx2/linksrc.hxx, 1.3.76.1
/sfx2/inc/sfx2/lnkbase.hxx, 1.3.76.1
/sfx2/source/appl/linksrc.cxx, 1.11.76.1
/sfx2/source/appl/lnkbase.cxx, 1.13.76.1
Comment 8 Oliver-Rainer Wittmann 2008-06-20 08:49:54 UTC 
OD->MRU: Checked in internal installation set of cws sw30bf06 - please verify.
Comment 9 eric.savary 2008-06-27 14:24:25 UTC 
Verified in cws sw30bf06
Comment 10 michael.ruess 2008-07-10 14:00:15 UTC 
Checked in DEV300m24.