Issue 89017 - osl_trace should emit trailing line feed to the debugger
Summary: osl_trace should emit trailing line feed to the debugger
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows XP
: P4 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: Frank Schönheit
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-05 10:10 UTC by Frank Schönheit
Modified: 2010-07-26 19:47 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch (813 bytes, patch)
2008-05-05 10:12 UTC, Frank Schönheit 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Frank Schönheit 2008-05-05 10:10:50 UTC 
Whenever I use OSL_TRACE on Windows, I am annoyed by the fact that, though it
nicely emits the trace string to the debugger (using OutputDebugString), it does
*not* emit the trailing line feed \n via this channel. Instead, the trace
message and the line feed are fed into stderr only.
This is ugly insofar as a) the debugger output is the only viable option to
capture traces on Windows, since stderr is not capture otherwise and b) you
cannot simply add the \n to your trace message, as this would be one line feed
too much for other platforms (where the default output channel to monitor trace
is stderr, where the \n in fact is appended).

The attached patch adds the line feed to the message emitted to OutputDebugString.
Comment 1 Frank Schönheit 2008-05-05 10:12:05 UTC 
Created attachment 53379 [details]
patch
Comment 2 kai.sommerfeld 2008-05-13 09:23:39 UTC 
target => 3.0
Comment 3 hennes.rohling 2008-05-30 13:55:08 UTC 
Retargeted.
Comment 4 Frank Schönheit 2008-05-30 21:11:40 UTC 
> Retargeted.

Uhm - seriously? Here is a rather trivial patch (which works for me). If you
don't have time for committing and the CWS overhead, please just review the
patch and say whether it is okay. In case it is, I'll happily commit myself.
Comment 5 kai.sommerfeld 2008-06-03 09:16:07 UTC 
hro: We should integrate this patch in 3.1
Comment 6 hennes.rohling 2008-08-15 14:45:04 UTC 
.
Comment 7 Frank Schönheit 2008-09-11 13:07:06 UTC 
fs->hro: Have just been annoyed by this, again ... any objections that I
integrate the patch my current CWS?
Comment 8 hennes.rohling 2008-09-15 09:59:03 UTC 
Added to CWS hro39
Comment 9 hennes.rohling 2009-01-26 12:52:33 UTC 
Fixed on CWS hro42
Comment 10 kai.sommerfeld 2009-02-19 08:47:19 UTC 
Unfortunately we missed the 3.1 code freeze deadline. Bug is fixed, but
respective CWS is not approved by QA. Really don't like this, but need to 
retarget the task to 3.2. Sorry.
Comment 11 kai.sommerfeld 2009-07-08 10:06:28 UTC 
Taking over... Patch applied to CWS kso32fixes.
Comment 12 kai.sommerfeld 2009-07-13 12:43:33 UTC 
fs: Please verify.
Comment 13 Frank Schönheit 2009-07-14 12:18:46 UTC 
found the patch in CWS kso32fixes - thanks!
Comment 14 Martin Hollmichel 2010-07-26 19:47:45 UTC 
close issue