Issue 93211 - Dependency missing for resource .src file on .hrc file
Summary: Dependency missing for resource .src file on .hrc file
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: ooo
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-28 14:31 UTC by ooo
Modified: 2013-08-07 15:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
solenv changes (15.36 KB, patch)
2008-08-29 13:09 UTC, hjs 		no flags Details | Diff
rscdep changes (tools) (2.45 KB, patch)
2008-08-29 13:11 UTC, hjs 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ooo 2008-08-28 14:31:00 UTC 
sc/${OUTPATH}/misc/core.dpr and sc/${OUTPATH}/misc/src.core.dprr lack a
dependency from compiler.src on the included compiler.hrc and its includes.

Furthermore, sc/${OUTPATH}/misc/*core.dpr* also list the apparently correct
dependencies for ..\..\..\common\srs\ui.srs  Other .src files in other
misc/*.dpr* also appear to have their dependencies.
Comment 1 hjs 2008-08-28 15:05:03 UTC 
tools/bootstrp/cppdep.cxx CppDep::IsIncludeStatement can't cope with comments (c
and c++ at first glance) on the include line. the result is a missing dependency.

the other issue is mixing dependencies from different directories. this is a
result of an unlucky naming scheme for *.dprr files (hint for the fix: replace
$(PWD:f) with $(TARGET))

moving the comments to their own code line is a workaround for the missing
dependencies. the second one won't hurt you but should be fixed anyway.
Comment 2 hjs 2008-08-29 13:09:35 UTC 
Created attachment 56089 [details]
solenv changes
Comment 3 hjs 2008-08-29 13:11:32 UTC 
Created attachment 56090 [details]
rscdep changes (tools)
Comment 4 hjs 2008-08-29 14:58:08 UTC 
committed
Comment 5 hjs 2008-08-29 14:58:43 UTC 
please verify
Comment 6 ooo 2008-09-01 10:43:47 UTC 
Applied the patches to my CWS, now dependencies include .hrc files and no
duplicated other directory's dependency list appears, fine.
Comment 7 ooo 2009-01-13 22:01:51 UTC 
Present in master, closing.