Issue 9398 - change so_predeliver mechanism
Summary: change so_predeliver mechanism
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta2
Assignee: Martin Hollmichel
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-20 10:32 UTC by Martin Hollmichel
Modified: 2003-06-16 16:52 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Martin Hollmichel 2002-11-20 10:32:04 UTC
to come to an unified SO/OOo build BUILD_SOSL will be removed.
for the so_predeliver mechanism BUILD_SOSL ocurrences will be changed to 
BUILD_PREDELIVER. this should the be triggered by a configure switch ?!
Comment 1 Martin Hollmichel 2002-11-20 10:33:58 UTC
target for this change will be SRX644 ;)
Comment 2 foskey 2002-11-20 11:45:25 UTC
Please define the configure switch and environment varaible that you
wish to use and I will code up the configure change for you.
Comment 3 hjs 2002-11-20 12:27:22 UTC
- to differetiate this from the PREDELIVER action in external modules
i would suggest something like BUILD_AUTODELIVER

- shouldn't this action be moved to the "build.pl"? it's the place
where the information about the module structure is collected. in my
understanding it's the only place to find out if building a module has
been completed. doing this out of makefiles may only be correct by chance.
Comment 4 hjs 2002-11-22 17:58:06 UTC
i just learned that there already is a "build -deliver". is there
still any need for the TG_DELIVER?
Comment 5 chris 2002-11-26 09:56:39 UTC
build.pl will automatically deliver.  I don't understand why
TG_DELIVER is there, but as you say it is redundant in OOo builds at
least.  If I remove the TG_DELIVER target and change the ALLTAR target to

ALLTAR : $(PACKAGE_DIR)$/so_predeliver

All seems to be fine.
Comment 6 hjs 2002-11-26 11:36:15 UTC
there is not need to define this dependency as is is already done
(beside others) in tg_ext.mk
Comment 7 chris 2002-11-27 11:35:18 UTC
Yes, I realised this too now :)

I've sucessfully completed a OO643C build now with these and my other
parallel changes, but I'm getting very strange runtime symbol errors
if I try to start OOo.  I'll file patches for the external
makefile.mks shortly.
Comment 8 Martin Hollmichel 2003-02-03 10:26:43 UTC
so_predeliver removed in zlib for 644
Comment 9 Martin Hollmichel 2003-04-07 16:39:33 UTC
removed all now.
Comment 10 Martin Hollmichel 2003-06-16 16:52:45 UTC
closed.