Issue 94947 - PerfTest: while loading Impress doc Office crashes on Linux/Solaris
Summary: PerfTest: while loading Impress doc Office crashes on Linux/Solaris
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: open-import (show other issues)
Version: DEV300_m33
Hardware: All Unix, all
: P1 (highest) Trivial (vote)
Target Milestone: OOo 3.1
Assignee: mst.ooo
QA Contact: issues@graphics
URL:
Keywords:
: 94924 94935 95309 (view as issue list)
Depends on:
Blocks:
 
Reported: 2008-10-15 13:15 UTC by chne
Modified: 2008-12-10 11:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
fix: re-insert accidentally removed hasProperty check (834 bytes, patch)
2008-10-17 09:55 UTC, mst.ooo 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description chne 2008-10-15 13:15:35 UTC 
While the Performace Tests is loading a test document the office crashes. This
causes also in the UI. Try to load the following document:

$SRC_ROOT/performancetest/data/performance-impress-1.odp

This Issue breaks the Performance-Test.

On Windows platform the crash does not ocur but the document is not loaded/displayed
Comment 1 chne 2008-10-16 12:20:52 UTC 
cn->af: stack id 15449
Comment 2 chne 2008-10-16 12:21:54 UTC 
*** Issue 94935 has been marked as a duplicate of this issue. ***
Comment 3 groucho266 2008-10-16 17:02:47 UTC 
This is a regression introduced by a fix for issue 93392: a property called
"ListId" is set at a property set without checking that the property is known by
the set and without catching any UnknownPropertyExceptions.  Such an exception
what causes the crash.  The property "ListId" is not known by
SvxUnoTextRangeBase.  The resulting exception is not caught and leads to the
termination of the office process.

The fix should be simple: either check for support of the property, like it is
done in the calling method XMLTextImportHelper::SetStyleAndAttrs at various
other places, or catch the UnknownPropertyException, or, best, do both.
Comment 4 groucho266 2008-10-16 17:06:15 UTC 
@MST: If I read the diffs of xmloff/source/text/txtimp.cxx correctly (and with
the recent switch to SVN I am not sure about that) then this fix went not only
into the DEV300 master.  Can you check that?
Comment 5 mst.ooo 2008-10-17 09:55:38 UTC 
Created attachment 57211 [details]
fix: re-insert accidentally removed hasProperty check
Comment 6 mst.ooo 2008-10-17 10:54:33 UTC 
ouch! it seems i accidentally removed the hasProperty check for ListId when
refactoring the list import for numbered-paragraph import.
attached a patch to fix that.
it seems to me that this completely breaks the impress ODF import, and thus,
various automated tests; raising priority to P1.

@af: as discussed, only DEV300 is affected
Comment 7 oliver.bolte 2008-10-17 11:27:29 UTC 
Fixed on MWS DEV300_m34.
Comment 8 oliver.bolte 2008-10-17 11:29:21 UTC 
@mst: verify, please
Comment 9 mst.ooo 2008-10-17 11:45:54 UTC 
verified on trunk
Comment 10 groucho266 2008-10-22 12:49:22 UTC 
*** Issue 95309 has been marked as a duplicate of this issue. ***
Comment 11 groucho266 2008-10-22 12:59:52 UTC 
*** Issue 94924 has been marked as a duplicate of this issue. ***
Comment 12 mst.ooo 2008-12-10 11:42:41 UTC 
close