Issue 96341 - [Automation] Remove loading of global filternames from master.inc
Summary: [Automation] Remove loading of global filternames from master.inc
Status: CLOSED FIXED
Alias: None
Product: QA
Classification: Unclassified
Component: testscripts (show other issues)
Version: current
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: joerg.skottke
QA Contact: issues@qa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-19 10:14 UTC by joerg.skottke
Modified: 2013-08-07 15:07 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description joerg.skottke 2008-11-19 10:14:10 UTC 
To speed up the test initialization we decided to remove the call to
GetDefaultFilterNames() from master.inc. 

The expected speed gain per test file is between 6 and 12 seconds, depending on
hardware/network speed.

Implementation:
- The call to GetDefaultFilterNames() is removed from master.inc::103
- The global variables are removed from gvariabl.inc
- A new (optional) include file is created
global/tools/includes/optional/t_ui_filters.inc
- The global variables and the functions GetDefaultFilterNames() and
hGetFilterGroup() are moved to the new file
- Following .bas files are updated to include (use) the new file:
  * first.bas
  * w_numbering.bas
  * w_formatcharacter.bas
  * w_xml_vertical_alignment.bas
  * m_lvl1.bas
  * g_export_html.bas
  * i_pengine.bas
  * i_slideshow.bas
  * dba_ctrl_TextControl.bas
Comment 1 joerg.skottke 2008-11-19 10:15:31 UTC 
Started
Comment 2 joerg.skottke 2008-11-19 10:24:08 UTC 
Sending        testautomation/dbaccess/optional/dba_ctrl_TextControl.bas
Sending        testautomation/framework/required/f_first.bas
Sending        testautomation/global/system/includes/gvariabl.inc
Sending        testautomation/global/system/includes/master.inc
Sending        testautomation/global/tools/includes/required/t_filters.inc
Sending        testautomation/graphics/optional/g_export_html.bas
Sending        testautomation/graphics/optional/i_pengine.bas
Sending        testautomation/graphics/optional/i_slideshow.bas
Sending        testautomation/math/optional/m_lvl1.bas
Sending        testautomation/writer/optional/w_formatcharacter.bas
Sending        testautomation/writer/optional/w_numbering.bas
Sending        testautomation/xml/optional/w_xml_vertical_alignment.bas
Transmitting file data ............
Committed revision 263969.

Adding         optional/t_ui_filters.inc
Transmitting file data .
Committed revision 263970.

Fixed.
Comment 3 joerg.skottke 2008-11-20 13:37:04 UTC 
Missed m_updt.bas (which uses gMathFilter in m_001_.inc)
Fixed.

Removed unused function hHandleAlienWarning() which used global filternames.
Comment 4 joerg.skottke 2008-11-20 13:40:57 UTC 
Sending        testautomation/global/system/includes/gvariabl.inc
Sending        testautomation/global/tools/includes/required/t_files.inc
Sending        testautomation/math/required/m_updt.bas
Transmitting file data ...
Committed revision 264055.

Removed now unused documentation from gvariable.inc
Comment 5 joerg.skottke 2009-01-08 09:28:56 UTC 
Code is gone in m38, closing