Apache OpenOffice (AOO) Bugzilla – Issue 96549
vcl/aqua/source/gdi deprecation warnings
Last modified: 2009-01-19 10:20:09 UTC
At least on Intel Mac OS X 10.5.5 with configure --enable-werror, building vcl fails with deprecation warnings in vcl/aqua/source/gdi ---8<--- /Users/stephan/DEV300m35/vcl/aqua/source/gdi/salgdi.cxx: In function 'bool AddTempFontDir(const char*)': /Users/stephan/DEV300m35/vcl/aqua/source/gdi/salgdi.cxx:1500: warning: 'ATSFontActivateFromFileSpecification' is deprecated (declared at /System/Library/Frameworks/ApplicationServices.framework/Frameworks/ATS.framework/Headers/AT SFont.h:283) /Users/stephan/DEV300m35/vcl/aqua/source/gdi/salgdi.cxx:1502: warning: 'ATSFontActivateFromFileSpecification' is deprecated (declared at /System/Library/Frameworks/ApplicationServices.framework/Frameworks/ATS.framework/Headers/AT SFont.h:283) /Users/stephan/DEV300m35/vcl/aqua/source/gdi/salgdi.cxx: In member function 'virtual bool AquaSalGraphics::AddTempDevFont(ImplDevFontList*, const String&, const String&)': /Users/stephan/DEV300m35/vcl/aqua/source/gdi/salgdi.cxx:1587: warning: 'ATSFontActivateFromFileSpecification' is deprecated (declared at /System/Library/Frameworks/ApplicationServices.framework/Frameworks/ATS.framework/Headers/AT SFont.h:283) /Users/stephan/DEV300m35/vcl/aqua/source/gdi/salgdi.cxx:1589: warning: 'ATSFontActivateFromFileSpecification' is deprecated (declared at /System/Library/Frameworks/ApplicationServices.framework/Frameworks/ATS.framework/Headers/AT SFont.h:283) ---8<---
@sb: since our MacOS build is targeted for OSX10.4 or newer we build with -DMAC_OS_X_VERSION_MIN_REQUIRED=1040 Please check the configure scripts why this isn't done in your build scenario.
@hdu: The only mention of MAC_OS_X_VERSION_MIN_REQUIRED in tags/DEV300_m35 is at tags/DEV300_m35/solenv/config/sdev300.ini@264268 l. 3729. So, while Sun-Hamburg setsolar environment obviously sets it (to 1010), configure environment does not.
Created attachment 58575 [details] Code patch
Hmm. Maybe the patch should actually use MAC_OS_X_MIN_ALLOWED rather than MAC_OS_X_MAX_ALLOWED? I think the patch may cause problems if you do get a successful build going with MACOSX_DEPLOYMENT_TARGET=10.4 or with the define option listed in the previous descriptions. (I couldn't get either to work for me, though.)
Created attachment 58578 [details] A better version of the patch.
@dyrcona: thanks for the patch! It will be useful once the deployment target moves to OSX>=10.5. I also updated the solenv module to set MAC_OS_X_VERSION_MIN_REQUIRED for all build environments on OSX. Fixed in CWS vcl97.
target
@hdu: I've got an even better version of the patch if you want it. The latest (third) patch moves the code to get the FSSpec from the FSRef to after the #else, since that is only needed for ATSFontActivateFromFileSpecification, which is the function deprecated in 10.5.
@dyrcona: already done. Please check salgdi.cxx in svn revision 264988.
Also the revision I mentioned in the previous comment had problems: On older SDKs the MAC_OS_X_VERSION_10_5 was not defined. The new salgdi.cxx in CWS vcl97 fixes this: http://svn.services.openoffice.org/ooo/cws/vcl97/vcl/aqua/source/gdi/salgdi.cxx
*** Issue 92820 has been marked as a duplicate of this issue. ***
@pl: please verify in CWS vcl97
verified
intergrated in m39, closing