Issue 97830 - GCF - grammar checking context menu may become too wide
Summary: GCF - grammar checking context menu may become too wide
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.0
Assignee: stefan.baltzer
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-07 12:45 UTC by thomas.lange
Modified: 2017-05-20 10:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.lange 2009-01-07 12:45:21 UTC 
If the suggestion form the proofreader gets too long the context menu will
become similar wide in order to display the full suggestion in one line.

The *display* of the suggestion should be clipped in order to prevent the
context menu from becoming too wide. Of course if the suggestion gets applied
the full text should be used.
Comment 1 thomas.lange 2009-01-07 12:45:47 UTC 
.
Comment 2 thomas.lange 2009-01-19 14:33:49 UTC 
Not time left to fix  this one in OO0 3.1 because of other issues.
Comment 3 thomas.lange 2009-10-12 13:07:43 UTC 
.
Comment 4 thomas.lange 2010-07-02 10:00:30 UTC 
.
Comment 5 thomas.lange 2010-10-07 11:42:15 UTC 
To reproduce: open Writer paste this
  aaaccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccczzz
and (when word is marked as misspelled) add it to a dictionary. Then remove a
character from within the string and open the context menu on the word once
more. -> The context menu should now suggest the word previously added to the
dictionary, and thus insulting in a very large menu.

Note: The above sample is rather artificial, but with grammar checking, where
whole text parts may be marked as incorrect it is a much more common case.
Comment 6 thomas.lange 2010-10-07 11:51:41 UTC 
tl->pl: as discussed, even if this is a rather specific use case, lets try for a
general solution that would be useful for all menus. 
It would be nice if menu entries were to support flags like
TEXT_DRAW_PATHELLIPSIS to handle this.

If the 3.4 time frame does not work out later on please don't re-target this
one, but instead assign it back to me and I will implement an isolated solution
for the spelling and grammar context menus in Writer and EditEngine
Comment 7 philipp.lohmann 2010-10-08 15:01:26 UTC 
Menu entries are now (as of CWS vcl116) limited to half the screen width (or at
least 400 pixel on small screens, a limit I pulled out of thin air).

On Mac however we have native menus which we don't really know the size of. I'll
try to come up with a sensible limitation there also.
Comment 8 philipp.lohmann 2010-10-11 12:50:14 UTC 
The mac native menu provides its own mechanism to do this (it inserts an
ellipsis in the middle), so no need for us to do anything special here.

Fixed in CWS vcl116
Comment 9 philipp.lohmann 2010-10-26 17:36:35 UTC 
please verify in CWS vcl116
Comment 10 stefan.baltzer 2010-10-28 13:51:38 UTC 
The current fix for this one limits the width of the main menus. Even in English
UI, several strings are cut. Examples (English UI, WinXP with DE keyboard):
"File - Save As   Strg+Umschalt+S" is cut to
"File - Save A... Strg+Umschalt+S"
"Insert - Indexes and Tables" is cut to 
"Insert - Indexes and Tab..."
-> Issue reopened
Comment 11 philipp.lohmann 2010-10-28 15:38:45 UTC 
good catch.

fixed now in CWS vcl116
Comment 12 stefan.baltzer 2010-11-01 17:07:17 UTC 
Well done. Verified in latest build of CWS vcl116 on Windows and Linux..