Issue 99665 - Charts in writer look ugly with anti-aliasing
Summary: Charts in writer look ugly with anti-aliasing
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@graphics
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2009-02-26 12:53 UTC by IngridvdM
Modified: 2013-02-24 21:19 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description IngridvdM 2009-02-26 12:53:31 UTC 
This is a follow up issue of issue 98289.
Create a default chart in a writer document, leave the chart edit mode and look
at the created metafile replacement. The contours of the columns, the grid lines
and the contours of the symbols in the legend look blurry. Switch of
anti-aliasing and those horizontal and vertical lines do display clear as they
should.
Comment 1 Armin Le Grand 2009-03-04 23:31:36 UTC 
AW: This should be relatively easy. When i think about it it should be because 
SW uses it's own OLE implementation (one more argument to CHANGE this) and does 
not set AA at the target OutDev when replaying the OLE's MetaFile.
Also adding some mildly interested people to CC here. Since i am on vacation, 
this task will be doable relatively quickly and it looks so official, i will 
also add some more people to CC.

AW->OD: Please try to encapsulate the SW's OLE MetaFile paint with:
- check if DrawingLayer AntiAliasing is on (grep for SvtDrawingLayerOptions)
- Switch AA On/Off accordingly (rescue and restore old state) at OutputDevice 
(HDU and PL can tell You how to do that at OutDev).

HTH, Greetings from vacation from Naples, Florida.
Comment 2 Oliver-Rainer Wittmann 2009-03-05 10:26:27 UTC 
Ok, taking over this task.

As discussed with HDU, I will switch On/Off AntiAliasing for embedded charts in
Writer according to the DrawingLayer AntiAliasing.
Comment 3 Oliver-Rainer Wittmann 2009-03-06 07:47:45 UTC 
On output of the replacement image of an embedded chart in Writer the
AntiAliasing mode at the output device is adopted -
ANTIALIASING_PIXELSNAPHAIRLINE is set - in case that AntiAliasing is activated
at the DrawingLayer.

Fixed in cws hb20 - changed files:
/sw/source/core/doc/notxtfrm.cxx
/sw/source/core/ole/ndole.cxx
/sw/inc/ndole.hxx
/sw/source/core/draw/dview.cxx
/sw/source/core/inc/dview.hxx
rev. 268967
Comment 4 Oliver-Rainer Wittmann 2009-03-06 10:23:32 UTC 
OD->MRU: Checked in internal installation of cws hb20 - please verify.
Comment 5 michael.ruess 2009-03-09 13:02:57 UTC 
Verified fix in CWS hb20 - Charts now look really smoother in AA mode.
Comment 6 michael.ruess 2009-03-27 10:23:11 UTC 
Checked in OOO310m7.