Created attachment 60644 [details]
Sardinian local data file (sc_IT)

Thank you. I spotted some details:

<QuotationStart>“</QuotationStart>
<QuotationEnd>”</QuotationEnd>
<DoubleQuotationStart>‘</DoubleQuotationStart>
<DoubleQuotationEnd>’</DoubleQuotationEnd>

These should be vice versa, Quotation denotes single quotes while
DoubleQuotation, well, denotes double quotes.


<TimeAM>a.m.</TimeAM>
<TimePM>p.m.</TimePM>

Really? Looks almost untranslated.


<IndexKey phonetic="false" default="true" unoid="alphanumeric">A-Z</IndexKey>

This in the Writer's generated index table will sort the index A-Z, and every
other character behind Z, using the default Unicode collation order. As
Sardinian appears to use accented characters, maybe those should be listed in
between at proper positions? See
http://svn.services.openoffice.org/ooo/trunk/i18npool/source/localedata/data/locale.dtd
for details.

<UnicodeScript>0</UnicodeScript>
<UnicodeScript>1</UnicodeScript>
<UnicodeScript>2</UnicodeScript>
<UnicodeScript>3</UnicodeScript>
<UnicodeScript>4</UnicodeScript>

Why 5 script ranges? Does Sardinian use other script ranges than 0 and 1?

<FollowPageWord>p.</FollowPageWord>
<FollowPageWord>pp.</FollowPageWord>

This looks untranslated. The FollowPageWord elements are used in the index table
as in "5 p." (page 5 and following) and "5 pp." (page 5 and following pages).


Other than those, the data file seems to be fine.

Hi er,

pls find my comments:

>>
<QuotationStart>“</QuotationStart>
<QuotationEnd>”</QuotationEnd>
<DoubleQuotationStart>‘</DoubleQuotationStart>
<DoubleQuotationEnd>’</DoubleQuotationEnd>

These should be vice versa, Quotation denotes single quotes while
DoubleQuotation, well, denotes double quotes.
>>
I've corrected this, it has been a mistake :)

>>
<TimeAM>a.m.</TimeAM>
<TimePM>p.m.</TimePM>

Really? Looks almost untranslated.
>>
No, it's ok, 'ante meridiano' and 'post meridiano' are latin inheritance and we
use it.

>>
<IndexKey phonetic="false" default="true" unoid="alphanumeric">A-Z</IndexKey>

This in the Writer's generated index table will sort the index A-Z, and every
other character behind Z, using the default Unicode collation order. As
Sardinian appears to use accented characters, maybe those should be listed in
between at proper positions? See
http://svn.services.openoffice.org/ooo/trunk/i18npool/source/localedata/data/locale.dtd
for details.
>>

I'm not sure of this but we use it like the Italian one, which has very similar
accentuation, so I think is ok. If you think we need to specify, pls advise.

>>
<UnicodeScript>0</UnicodeScript>
<UnicodeScript>1</UnicodeScript>
<UnicodeScript>2</UnicodeScript>
<UnicodeScript>3</UnicodeScript>
<UnicodeScript>4</UnicodeScript>

Why 5 script ranges? Does Sardinian use other script ranges than 0 and 1?
>>
Corrected

>>
<FollowPageWord>p.</FollowPageWord>
<FollowPageWord>pp.</FollowPageWord>

This looks untranslated. The FollowPageWord elements are used in the index table
as in "5 p." (page 5 and following) and "5 pp." (page 5 and following pages).
>>
If you mean 'following page/s' we need to change it.

I'll submit a new local data file.

Created attachment 60811 [details]
'Corrected' Sardinian local data file

>> <QuotationStart>“</QuotationStart>
>> <QuotationEnd>”</QuotationEnd>
>> <DoubleQuotationStart>‘</DoubleQuotationStart>
>> <DoubleQuotationEnd>’</DoubleQuotationEnd>
>> 
>> These should be vice versa, Quotation denotes single quotes while
>> DoubleQuotation, well, denotes double quotes.
>
> I've corrected this, it has been a mistake :)

Umm.. now single/double quotes are used correctly, but they are the
ASCII quote characters instead of the typographic characters that were
used before. I think the typographic ones were correct.

>> <IndexKey phonetic="false" default="true" unoid="alphanumeric">A-Z</IndexKey>
> 
> I'm not sure of this but we use it like the Italian one, which has very similar
> accentuation, so I think is ok. If you think we need to specify, pls advise.

If Italians are happy with the sort order of the index it's fine :-)


> <FollowPageWord>p.</FollowPageWord>
> <FollowPageWord>pp.</FollowPageWord>
> 
> This looks untranslated. The FollowPageWord elements are used in the index table
> as in "5 p." (page 5 and following) and "5 pp." (page 5 and following pages).
> >>
> If you mean 'following page/s' we need to change it.

Yes, that's meant.

Thanks
  Eike

>> <QuotationStart>“</QuotationStart>
>> <QuotationEnd>”</QuotationEnd>
>> <DoubleQuotationStart>‘</DoubleQuotationStart>
>> <DoubleQuotationEnd>’</DoubleQuotationEnd>
>> 
>> These should be vice versa, Quotation denotes single quotes while
>> DoubleQuotation, well, denotes double quotes.
>

>Umm.. now single/double quotes are used correctly, but they are the
>ASCII quote characters instead of the typographic characters that were
>used before. I think the typographic ones were correct.

Hi Eike,

Can you change them directly or do I have to do it by myself?

Thanks,
Valter

I can change them, no problem. However, as you generated the file with the it46
generator it may be considered to be submitted to the Unicode CLDR repository if
there doesn't already exist a locale data set, so if possible you should correct
it at it46 as well.
Thanks
  Eike

Reassigning to spare time account.

Ah, I almost forgot:

Valter, did you already send a signed Contributor Agreement form (SCA)?
If not, please do so, see
http://wiki.services.openoffice.org/wiki/Sun_Contributor_Agreement

Thanks
  Eike

>Ah, I almost forgot:
>
>Valter, did you already send a signed Contributor Agreement form (SCA)?

Hi Eike,

yes I already did. Sent on 02/07th/2009 to copyrightfax@sun.com in attachment.
If you need it, I can send one copy to you.
Do the other collaborators have to do the same?

Regards,
Valter

In cws locales32:

revision 273180
i18npool/source/localedata/data/localedata_euro.map
i18npool/source/localedata/data/makefile.mk
i18npool/source/localedata/data/sc_IT.xml
i18npool/source/localedata/localedata.cxx

@valterubuntu:
[... SCA ...]
> Sent on 02/07th/2009 to copyrightfax@sun.com in attachment.
> If you need it, I can send one copy to you.

Not necessary. However, listing of SCAs got stuck, please add yourself
to http://wiki.services.openoffice.org/wiki/Pending_JCAs

> Do the other collaborators have to do the same?

Not needed if the person who actually submits the translation or other
files signed the SCA. Anyway, clarify in your group that all work will
be contributed to OOo under the SCA.

Reassigning to QA for verification.

sba: Reassigned to me. (I guess owner "sab" was a typo :-)

Verified in CWS locales32.

OK in DEV300_m60. Closed.