This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 105605 - GTK L&F: toolbar dragger looks ugly
Summary: GTK L&F: toolbar dragger looks ugly
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 6.x
Hardware: All Linux
: P3 blocker (vote)
Assignee: mslama
URL:
Keywords: GTK, L&F
Depends on:
Blocks:
 
Reported: 2007-06-04 16:00 UTC by Antonin Nebuzelsky
Modified: 2008-12-22 13:54 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Screenshot (22.64 KB, image/png)
2007-06-04 16:01 UTC, Antonin Nebuzelsky 		Details
swingset-human (8.84 KB, image/png)
2007-07-03 16:11 UTC, mslama 		Details
swingset-nimbus (14.61 KB, image/png)
2007-07-03 16:11 UTC, mslama 		Details
ide-human (7.57 KB, image/png)
2007-07-03 16:12 UTC, mslama 		Details
ide-nimbus (20.47 KB, image/png)
2007-07-03 16:14 UTC, mslama 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2007-06-04 16:00:27 UTC 
Ubuntu Linux, JDK 6.0u2, custom theme (Simple controls, Metabox window borders)

The toolbar dragger looks like it is missing the right and bottom border/shadow.
See the attached screenshot where is comparison of our toolbar with SwingSet2
demo's toolbar.

The result is that our toolbar dragger looks ugly.
Comment 1 Antonin Nebuzelsky 2007-06-04 16:01:46 UTC 
Created attachment 43192 [details]
Screenshot
Comment 2 Antonin Nebuzelsky 2007-06-26 14:58:22 UTC 
To be fixed soon, TM = 6.0beta1.
Comment 3 David Simonek 2007-06-27 11:50:46 UTC 
Marku, do we draw dragger by ourselves?
Comment 4 mslama 2007-06-27 11:59:09 UTC 
I will look at it. We retrieve UI resource (icon) from L&F.
Comment 5 mslama 2007-07-03 15:44:55 UTC 
Painting of dragger icon is inconsistent. To make it looking better I increased height of dragger and have to paint it
from y=-1 instead of y=0. I attach some screenshots of SwingSet2 and IDE for Nimbus and Human (Ubuntu) theme. Please
check another themes.
Comment 6 mslama 2007-07-03 16:00:17 UTC 
Increased height of dragger icon for GTK L&F:
/cvs/openide/loaders/src/org/openide/awt/Toolbar.java
new revision: 1.51; previous revision: 1.50

Tested with JDK 7 b14.
Comment 7 mslama 2007-07-03 16:10:26 UTC 
Fix has nothing to do with right shadow border of dragger. Code retrieves dragger width (ie. our code does not set it)
and then invoke paint into given region which has width set to width returned by L&F. I tried simple controls (customize
Human theme) but I have no idea where shadow (border) between dragger and rest of toolbar in SwingSet2 comes from. (In
other words who is responsible for shadow painting.) I can only say that it is NOT part of dragger.
Comment 8 mslama 2007-07-03 16:11:10 UTC 
Created attachment 44676 [details]
swingset-human
Comment 9 mslama 2007-07-03 16:11:40 UTC 
Created attachment 44677 [details]
swingset-nimbus
Comment 10 mslama 2007-07-03 16:12:06 UTC 
Created attachment 44678 [details]
ide-human
Comment 11 mslama 2007-07-03 16:14:08 UTC 
Created attachment 44679 [details]
ide-nimbus
Comment 12 Petr Chytil 2007-07-12 13:00:40 UTC 
verified in Ubuntu (Simple/Metabox).

Product Version: NetBeans IDE Dev (Build 200707120000) 
Java: 1.6.0_02; Java HotSpot(TM) Client VM 1.6.0_02-b05 
System: Linux version 2.6.20-16-generic running on i386; UTF-8; en_US (nb) 
Userdir: /home/petr/.netbeans/dev