This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 11558 - NbErrorManager should handle USER level exception in better way
Summary: NbErrorManager should handle USER level exception in better way
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: David Simonek
URL: http://www.netbeans.org/www-nbdev/msg...
Keywords: UI
Depends on:
Blocks: 9631
  Show dependency tree
 
Reported: 2001-04-19 13:15 UTC by Jaroslav Tulach
Modified: 2008-12-22 09:53 UTC (History)
4 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
patch for RenameAction.java (3.51 KB, patch)
2001-04-20 16:39 UTC, Josef Kozak
Details | Diff
patch for NbErrorManager.java (2.33 KB, patch)
2001-04-20 16:44 UTC, Josef Kozak
Details | Diff
patch for NotifyException.java (1.85 KB, patch)
2001-04-20 16:45 UTC, Josef Kozak
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2001-04-19 13:15:32 UTC
As written in http://www.netbeans.org/www-nbdev/msg05953.html and related
messages in the thread by Josef, it would be nice if ErrorManager could be used
for reporting more user friendly messages than the currently used.

Josef submitted patches. I applied the one for RenameAction, but I do not think
that extending the constants in ErrorManager is necessary, I would rather
preffer different behavior (title + icon) for ErrorManager.USER,
ErrorManager.WARNING, etc.

Also the patch for NbErrorManager is not correct, it should be moved to
NotifyException class, otherwise could lead to deadlocks.

Last but not least, it would be IMHO better to share same dialog as the
exceptions are shown right now. But, of course with different title and buttons
+ USER exceptions would be have to be displayed first.
Comment 1 Josef Kozak 2001-04-20 16:38:03 UTC
I corrected RenameAction.java  and  NbErrorManager.java as Jesse suggested. 
So now annotation with USER or WARNING severity with localized message 
are not printed to console and ide.log because these are user-friendly messages.

The piece of code which must be called from AWT thread I moved to 
NotifyException.java. 
(see the thread http://www.netbeans.org/www-nbdev/msg05953.html )

So here are the patches...
Comment 2 Josef Kozak 2001-04-20 16:39:40 UTC
Created attachment 1186 [details]
patch for  RenameAction.java
Comment 3 Josef Kozak 2001-04-20 16:44:12 UTC
Created attachment 1187 [details]
patch for  NbErrorManager.java
Comment 4 Josef Kozak 2001-04-20 16:45:51 UTC
Created attachment 1188 [details]
patch for  NotifyException.java
Comment 5 Jaroslav Tulach 2001-04-23 07:27:07 UTC
I've applied the Josef's latest patch, NotifyException.java rev. 1.22, but I
still think that the UI should be improved to share only one dialog box for
exceptions with all kinds of severity (WARNING, USER, EXCEPTION, ...) as
described above.
Comment 6 Jan Chalupa 2001-05-05 20:28:05 UTC
Target milestone -> 3.3
Comment 7 Josef Kozak 2001-05-08 14:59:20 UTC
I applied patch for RenameAction.java which I sent last time. It is small 
change, now only exceptions without USER or WARNING severity are printed to 
console. The same problem was in 
org/openide/explorer/view/TreeViewCellEditor.java, see issue #11991. Now it is 
consistent in both files.
Comment 8 Jaroslav Tulach 2001-06-19 19:11:41 UTC
Just a comment: Rosta, please keep in mind, that we would like to move the whole
code of NbErrorManager to logger module, when Roger will be ready to take care
of it. So the less core features used, the better...
Comment 9 Jan Chalupa 2001-08-27 15:51:48 UTC
Adjusting target milestone.
Comment 10 Marian Mirilovic 2001-12-04 13:40:26 UTC
remove keyword :3.2.1_CANDIDATE
and changed Target Milestone : 3.2.1 -> ---
Comment 11 David Simonek 2002-07-26 13:43:58 UTC
Ok, patches already exist, while not perfect -> target set to 4.0.
I'll reapply the patch, try to make suggested changes and pass to UI
for review.
Comment 12 Marian Mirilovic 2002-12-06 17:57:37 UTC
reassigne to Marek, new owner of ui subcomponents
Comment 13 Marian Mirilovic 2003-01-16 16:14:24 UTC
Really old issue, patch is here, but nobody aplied it, why ?
Comment 14 mslama 2004-04-19 15:05:28 UTC
Assigning to Tim
Comment 15 Jan Chalupa 2004-11-01 16:50:43 UTC
Re-assigning Tim's issues to Dafe.
Comment 16 _ rkubacki 2007-01-04 20:12:41 UTC
Jarda, I think we tried to get rid of USER level exceptions and want to migrate
to logging API anyway so I am closing this as WONTFIX. Is this correct?