This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 115770 - Only quote identifiers when necessary when generating SQL
Summary: Only quote identifiers when necessary when generating SQL
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: Macintosh All
: P3 blocker (vote)
Assignee: _ jimdavidson
URL:
Keywords:
Depends on:
Blocks: 114416
  Show dependency tree
 
Reported: 2007-09-18 00:49 UTC by David Vancouvering
Modified: 2008-11-18 13:22 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Vancouvering 2007-09-18 00:49:51 UTC
Use org.netbeans.api.db.sql.support.SQLIdentifiers.Quoter to quote identifiers in generated SQL only when this is
needed, to improve readability of generated SQL.
Comment 1 _ jimdavidson 2007-09-21 17:58:23 UTC
Update query generation in both databinding and query editor to use new Quoter API for selective quoting.

Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querybuilder/QueryBuilder.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querybuilder/QueryBuilder.java,v  <-- 
QueryBuilder.java
new revision: 1.12; previous revision: 1.11
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querybuilder/QueryModel.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querybuilder/QueryModel.java,v  <--  QueryModel.java
new revision: 1.5; previous revision: 1.4
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/AndNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/AndNode.java,v  <--  AndNode.java
new revision: 1.3; previous revision: 1.2
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/ColumnItem.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/ColumnItem.java,v  <--  ColumnItem.java
new revision: 1.3; previous revision: 1.2
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/ColumnNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/ColumnNode.java,v  <--  ColumnNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/FromNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/FromNode.java,v  <--  FromNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/GroupByNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/GroupByNode.java,v  <--  GroupByNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/HavingNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/HavingNode.java,v  <--  HavingNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/Identifier.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/Identifier.java,v  <--  Identifier.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/JoinRestriction.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/JoinRestriction.java,v  <-- 
JoinRestriction.java
new revision: 1.3; previous revision: 1.2
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/JoinTableNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/JoinTableNode.java,v  <-- 
JoinTableNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/Literal.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/Literal.java,v  <--  Literal.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/NotNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/NotNode.java,v  <--  NotNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/OrNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/OrNode.java,v  <--  OrNode.java
new revision: 1.3; previous revision: 1.2
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/OrderByNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/OrderByNode.java,v  <--  OrderByNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/Predicate.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/Predicate.java,v  <--  Predicate.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/QueryItem.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/QueryItem.java,v  <--  QueryItem.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/QueryNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/QueryNode.java,v  <--  QueryNode.java
new revision: 1.5; previous revision: 1.4
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/SelectNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/SelectNode.java,v  <--  SelectNode.java
new revision: 1.5; previous revision: 1.4
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/SetFunction.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/SetFunction.java,v  <--  SetFunction.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/SortSpecification.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/SortSpecification.java,v  <-- 
SortSpecification.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/TableNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/TableNode.java,v  <--  TableNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/WhereNode.java;
/cvs/db/visualsqleditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/WhereNode.java,v  <--  WhereNode.java
new revision: 1.4; previous revision: 1.3
done
Checking in
visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/explorer/RowSetBeanCreateInfoSet.java;
/cvs/visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/explorer/RowSetBeanCreateInfoSet.java,v
 <--  RowSetBeanCreateInfoSet.java
new revision: 1.5; previous revision: 1.4
done
Checking in
visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/model/DatasourceTransferManager.java;
/cvs/visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/model/DatasourceTransferManager.java,v
 <--  DatasourceTransferManager.java
new revision: 1.21; previous revision: 1.20
done
Checking in visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/sql/DatabaseMetaDataHelper.java;
/cvs/visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/sql/DatabaseMetaDataHelper.java,v 
<--  DatabaseMetaDataHelper.java
new revision: 1.2; previous revision: 1.1
done
Checking in visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/sql/DesignTimeDataSource.java;
/cvs/visualweb/dataconnectivity/src/org/netbeans/modules/visualweb/dataconnectivity/sql/DesignTimeDataSource.java,v  <--
 DesignTimeDataSource.java
new revision: 1.8; previous revision: 1.7
done
Comment 2 Petr Blaha 2008-11-18 13:22:08 UTC
Move visualsqleditor subcomponents below visualweb