This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 133018 - TagBasedLexerFormatter may leave locked Document
Summary: TagBasedLexerFormatter may leave locked Document
Status: RESOLVED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Tomasz Slota
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-16 15:54 UTC by Jan Lahoda
Modified: 2008-04-25 13:14 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2008-04-16 15:54:29 UTC 
[recent sources]

In editor.structure/src/org/netbeans/modules/editor/structure/formatting/TagBasedLexerFormatter.java, an atomicLock is
acquired, but the code has a path on which the lock will not be unlocked (if there is no TokenHierarchy for the
Document). Although this probably should not happen in practice, it is a very bad practice, and should be fixed.
Comment 1 Samaresh Panda 2008-04-16 21:44:30 UTC 
The module is no longer part of xml. It is maintained by Marek Fukala. And I do not know the appropriate component/sub
component hence assigning to mfukala for his input.
Comment 2 Tomasz Slota 2008-04-18 09:56:25 UTC 
Fixed,

Change log:

http://hg.netbeans.org/main/rev/9e88a0f84320