This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 149015 - fix for 134912 should be into trunk
Summary: fix for 134912 should be into trunk
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Peter Zavadsky
URL: http://hg.netbeans.org/release61/rev/...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-03 00:33 UTC by Masaki Katakai
Modified: 2008-10-08 05:29 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Diff of suggested fix (2.45 KB, text/plain)
2008-10-03 20:10 UTC, Peter Zavadsky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2008-10-03 00:33:39 UTC
The P1 issue (http://www.netbeans.org/issues/show_bug.cgi?id=134912) has
been fixed in release61 but not in trunk.

Can anyone apply the change below to trunk?

http://hg.netbeans.org/release61/rev/44c00b01dce7
Comment 1 Peter Zavadsky 2008-10-03 02:27:36 UTC
I need to have a look at that issue closer, to find out whether really and why it was not integrated into trunk. Thanks.
Comment 2 Peter Zavadsky 2008-10-03 17:39:23 UTC
Investigating the issue, and the changeset.
Comment 3 Peter Zavadsky 2008-10-03 20:10:54 UTC
Created attachment 71137 [details]
Diff of suggested fix
Comment 4 Peter Zavadsky 2008-10-03 20:25:42 UTC
The fix is prepared, looking for a way, to get it approved.
Comment 5 Peter Zavadsky 2008-10-03 22:51:58 UTC
Fixed (after contacting Dongmei)

changeset:   105040:1a5b73bf02de
tag:         tip
user:        Peter Zavadsky <pzavadsky@netbeans.org>
date:        Fri Oct 03 14:13:49 2008 -0700
summary:     #149015 Applying fix from 6.1 branch to trunk.
Comment 6 Quality Engineering 2008-10-04 09:21:48 UTC
Integrated into 'main-golden', will be available in build *200810040600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/1a5b73bf02de
User: Peter Zavadsky <pzavadsky@netbeans.org>
Log: #149015 Applying fix from 6.1 branch to trunk.
Comment 7 Masaki Katakai 2008-10-04 10:04:05 UTC
Thank you Peter!

There is one missing file. These 3 lines need to be added to project.properties
so that it copies those localized jar files to modules/ext/locale/.

--- a/visualweb.woodstock.webui.jsf/nbproject/project.properties
+++ b/visualweb.woodstock.webui.jsf/nbproject/project.properties
@@ -52,6 +52,9 @@ release.external/woodstock-components-4.
release.external/woodstock-components-4.2.zip!/jsf-extensions-dynamic-faces-0.1.jar=modules/ext/jsf-extensions-dynamic-faces-0.1.jar
release.external/woodstock-components-4.2.zip!/json-2.jar=modules/ext/json-2.jar
release.external/woodstock-components-4.2.zip!/webui-jsf-dt.jar=modules/ext/webui-jsf-dt.jar
+release.external/woodstock-components-4.2.zip!/webui-jsf-dt_ja.jar=modules/ext/locale/webui-jsf-dt_ja.jar
+release.external/woodstock-components-4.2.zip!/webui-jsf-dt_pt_BR.jar=modules/ext/locale/webui-jsf-dt_pt_BR.jar
+release.external/woodstock-components-4.2.zip!/webui-jsf-dt_zh_CN.jar=modules/ext/locale/webui-jsf-dt_zh_CN.jar
release.external/woodstock-components-4.2.zip!/webui-jsf.jar=modules/ext/webui-jsf.jar
release.external/woodstock-components-4.2.zip!/webui-jsf-doc.zip=docs/webui-jsf-doc.zip
release.external/woodstock-components-4.2.zip!/webui-jsf-src.zip=docs/webui-jsf-src.zip 
Comment 8 Peter Zavadsky 2008-10-06 20:16:10 UTC
Masaki, thanks for pointing that out.
I just added the missing change.

changeset:   105163:0e38d2f36b7f
tag:         tip
user:        Peter Zavadsky <pzavadsky@netbeans.org>
date:        Mon Oct 06 11:06:08 2008 -0700
summary:     #149015 Missing part of the original fix.
Comment 9 Quality Engineering 2008-10-07 06:05:35 UTC
Integrated into 'main-golden', will be available in build *200810070201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/0e38d2f36b7f
User: Peter Zavadsky <pzavadsky@netbeans.org>
Log: #149015 Missing part of the original fix.
Comment 10 Masaki Katakai 2008-10-08 05:29:06 UTC
verified the fix on 200810071401.

Thank you very much Petr!