This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 14941 - Please remove static icons and bundles from VcsGroupSettingsBeanInfo.java
Summary: Please remove static icons and bundles from VcsGroupSettingsBeanInfo.java
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P3 blocker (vote)
Assignee: issues@obsolete
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 14943
  Show dependency tree
 
Reported: 2001-08-30 11:14 UTC by Petr Nejedly
Modified: 2003-07-01 12:58 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2001-08-30 11:14:05 UTC 
Static icons and bundles are considered a memory leak in this context.
Comment 1 Milos Kleint 2001-08-30 12:44:57 UTC 
fixed in tommorow's build (31/Aug/2001)
Comment 2 Petr Nejedly 2001-08-30 13:24:58 UTC 
x
Comment 3 Petr Nejedly 2001-10-17 16:53:34 UTC 
Please review also newly added BIs:
VcsVersioningSystemBeanInfo.java
wizard/mountcvs/CvsMountFSBeanInfo.java
settings/VcsSettingsBeanInfo.java
settings/GeneralVcsSettingsBeanInfo.java 
search/VcsSearchTypeBeanInfo.java

Problems: static data, static initializers.
Comment 4 Martin Entlicher 2001-10-18 12:52:41 UTC 
Fixed. Static initializers removed, initialization is done when data
are needed.
Comment 5 Petr Nejedly 2001-10-19 09:02:02 UTC 
The intent was to get rid of all the static data from the BIs,
especially the images. Use Utilities.loadImage for icons,
and don't cahce anything in BIs, the system will cache for you
the better way.

BTW: Do you like how these BIs look like? Especially that 30+ line
monstrum getIcon which can be replaced by 5 nice lines.
Comment 6 Martin Entlicher 2001-10-19 14:12:29 UTC 
O.K., so I will remove all static data from there.

> BTW: Do you like how these BIs look like? Especially that 30+ line
> monstrum getIcon which can be replaced by 5 nice lines.

No, I would not wrote it if it would not be generated from the
template for me.
Comment 7 Martin Entlicher 2001-10-19 14:39:27 UTC 
Fixed for all BeanInfo listed and also for
vcsgeneric/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystemBeanInfo
No static data left there.
Comment 8 Petr Nejedly 2001-10-19 15:24:05 UTC 
OK now.
Comment 9 Quality Engineering 2003-07-01 12:58:06 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.