This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I have a Themes.xml file that I was using to test my own a11y compatibility for a wizard I created using the openapi's wizard templates. Due to the size of the font, 18 point, the setup wizard did not show portions of the first panel. The change in font size also impacts all my wizard panels.
Created attachment 4087 [details] a themes xml file
a11y is module, this is A11Y issue .
the problem is not solvable. Using too large font is similar to trying to run the IDE with VGA standard resolution. Not A11Y per se because the low-vision users have other means to read the screen text (zooming SW)
I was able to make a change to the openide file WizardDescriptor.java, method createContentPanel(boolean) that alleviated the problems with my wizard. What I did was to remove the line that set the preferred size of the left pane (called contentPanel) of the wizard. Is this not a viable thing to do to help mitigate some of the a11y issues? If this line is not there, my wizard seems to resize well without having to calculate and set the preferred size of my panels.
FWIW, I've been talking with other folks about this issue since Trung closed it. Here are some observations I've put together: - most or all of the dialogs in NetBeans size themselves reasonably when a larger font is used. Why should the wizards be different? - I think one of the accessibility requirements is that things should be able to cope with fonts that are twice the size of the default. (yes, there are zooming tools. But, if you just need the text a little larger, it would be nicer to avoid the hassle of using one of those tools) - Even ignoring a11y issues, there are l10n issues here. German text will make all the text longer. Chinese will generally involve using a larger font size. The wizards may need to resize to accomodate these. All of this suggests that some kind of auto-resizing should be done by the wizards, I think.
I still maintain that this is not a A11Y bug per se because the user can alway make the wizard larger herself. Annoying? Yes! HIE folks, the ball is on your court. Please come up with the sizing algorithm which works well for _all_ users. We can remove the setPreferredSize(<hard coded value>) as Hernandez suggested but then the width of the content pane will change when its content changes between the steps.
More thoughts: if we make the left side content pane resizable we need to resize the background image too. Need to make it resize-friendly.
Jano, please drive the discusion among UI/HIE folks to define the sizing algorithm, then reassign the issue back to me. Thanks
Well, as an initial guess, I would say the sizing algorithm should be: find the maximum preferred size of all the pages in the wizard, then constrain that by the size of the screen so it doesn't show up larger than the screen, and set the wizard to be that new size. Would that work?
David John, that could work in ideal world, perhaps. Current NB wizard framework doesn't allow to get all wizard panels at wizard invocation time. It is because: * it would be too expensive to compute preferred size of all panels * some panels can change their content dynamically according to user input in previous steps * preferred size of swing components depends also on presented data. But the data can depend on previous steps. We want to achieve two requirements: 1. display whole content of each wizard panel 2. do not resize wizard panels Due to constraints specified above I propose following: * For default font size, language, look and feel, and other attributes that affect size of panels assure that both requirements are satisfied * For other than default settings satisfy first requirement Related to resizing of steps panel. I do not agree that width of steps panel should change according to font size. Steps panel is inserted inside scrollable pane, so all steps can be made visible. There is also image resizing issue that Trung mentioned. Current state is fine with me.
What jrojcek said in the previous comment is exactly the current state. Should I close the issue as INVALID?
I am not sure that current state is exactly same to what I wrote. I can read in bug description that portions of the first setup wizard panel are not shown. I called for always displaying whole wizard panels. Perhaps I didn't express it very well. So, please, do not close the bug as invalid.
Target milestone was changed from '3.4' to TBD.
Set terget milestone to TBD
I agree with your proposal of satisfying both requirements at normal font sizes, and only satisfying the first (making sure everything is shown (when it isn't larger than the screen)) in other circumstances. And I also agree that this isn't what happens at the moment.
*** Issue 33248 has been marked as a duplicate of this issue. ***
Marking as I18N for now since this is like issues we are now filing to enable Chinese localizations - Chinese l10n needs to use larger font than default 11 point; so using larger font, plus longer string length of translated strings and that multibyte is used means issues like this one will show more often. ( We realize its also general and a11y issue also) Marking with FONTSIZE keyword since those issues will not be tracked on quality dashboard for s1s or nb3.5 english fcs. Raising to p2 as these kinds of issues will probably need fixing for the Chinese nevada and 3.5 release instead of 4.0, based on base team decision.
Created attachment 10369 [details] showing one of the resize issues
Created attachment 10656 [details] diff of the patch which solves the problem
fixed in main trunk. /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.java,v <-- IDESettingsPanel.java new revision: 1.32; previous revision: 1.31 /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.form,v <-- IDESettingsPanel.form new revision: 1.14; previous revision: 1.13
Merged into release35 branch: /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.java,v <-- IDESettingsPanel.java new revision: 1.28.12.2; previous revision: 1.28.12.1 /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.form,v <-- IDESettingsPanel.form new revision: 1.13.12.1; previous revision: 1.13
Created attachment 10723 [details] radio b. text is still not fully visible
reopening -> radio button texts aren't still fully visible. Maybe general issue ?
Hm, on Netbeans everything works well. No idea where the problem can be. Anybody else will try?
Created attachment 10737 [details] second patch (to be applied together with first one)
OK, I think I have something - JTextArea is not able to compute its pref size without rows and columns count specified. So I added correct rows and columns, problems seem to be solved. However! if S1S texts in english or chinese localization will be significantly longer (say 2x) then netbeans ones, problems will return and there's no easy or good way I know to solve such situation. For now it seems to be OK.
fixed again in main trunk. cvs log: /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.java,v <-- IDESettingsPanel.java new revision: 1.33; previous revision: 1.32 /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.form,v <-- IDESettingsPanel.form new revision: 1.15; previous revision: 1.14
reviewed
merged into release35 branch: /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.java,v <-- IDESettingsPanel.java new revision: 1.28.12.3; previous revision: 1.28.12.2 /cvs/core/src/org/netbeans/core/ui/IDESettingsPanel.form,v <-- IDESettingsPanel.form new revision: 1.13.12.2; previous revision: 1.13.12.1
I've verified the fixing in followings. - S1S nevada Build 030625 - win2000 chinese, solaris 9 chinese - j2sdk1.4.1_02 Thank you for the fixing and Thank you all !!! Hiroshi