This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 21458 - CVS: Ask user for keyword substitution if file is not recognized.
Summary: CVS: Ask user for keyword substitution if file is not recognized.
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P1 blocker with 1 vote (vote)
Assignee: Martin Entlicher
Keywords: UI
Depends on:
Blocks: 35640 41243 51807
  Show dependency tree
Reported: 2002-03-12 09:31 UTC by Jiri Kovalsky
Modified: 2005-07-19 14:34 UTC (History)
0 users

See Also:
Exception Reporter:


Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2002-03-12 09:31:16 UTC
Development build #200203110100 of NetBeans 3.4 on Windows 2000 with JDK 1.4 b92

If user decides to add a file that IDE is not able to recognize, please ask user
whether it should be considered as text or binary. I would even propose not to
inspect the contents with some heuristics, just ask user ! This may lead to data
loss that will make user pretty angry like me :-(

Steps to reproduce:
1. Mount CVS filesystem using Command-line client.
2. Create StarOffice presentation underneath.
3. Right click this [Local] node and choose "CVS|Add".
4. No question shows up, just adding dialog.
Comment 1 Martin Entlicher 2002-03-12 14:05:53 UTC
I suggest to read first 1000 characters. If they are all > 30,
consider it as text, if not, ask the user with a text like "This might
be a binary file".

What to do if there are more than one file selected? Should there be
some table with file names and check-boxes for binary flag?

Any other thoughts?
Comment 2 Filip Rachunek 2002-04-30 15:52:02 UTC
UI keyword added.
Comment 3 Marek Grummich 2002-07-22 08:15:13 UTC
Target milestone was changed from not determined to TBD
Comment 4 dmladek 2003-02-20 14:25:12 UTC
...checking bugs and found out this:

don't we have too many opened bugs for one thing? Please, see:
 issue #31056
 issue #30112

I suggest to mark 2 of them as duplicats for one of those 3
Comment 5 Martin Entlicher 2004-03-31 13:13:11 UTC
Scheduling for promo-D.
Comment 6 Martin Entlicher 2004-09-17 13:02:03 UTC
This didn't made it into promotion-D :-(
The UI of Add command needs to be changed and it's too late to do this
into 4.0 (it's after UI freeze).
This needs to be resolved in the next release, scheduling for promo-E.
Comment 7 _ pkuzel 2005-01-05 15:23:21 UTC
Other IDEs use table here.

It 4.1 timeframe I can implement simple chooser:

  o Autodetect (based on CVS repository setup)
  o Treat as binary (no textual diffs)
  o Treat as textual (harms binary files)

The first option would be default because it works in most cases and
covers well recursive structures too).
Comment 8 Jiri Kovalsky 2005-01-05 15:36:40 UTC
Let me repeat that Martin's algorithm matched correct type in ~200
files I used for the testing. Please consider his work too.
Comment 9 _ pkuzel 2005-01-06 15:02:02 UTC
FIXED the chooser is implemented.

Checking in
new revision: 1.53; previous revision: 1.52
Checking in
 <--  cvs.xml
new revision: 1.112; previous revision: 1.111
Comment 10 Peter Pis 2005-07-19 14:34:04 UTC