This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220816 - OptionsPanelController.handleSuccessfulSearch not invoked when search text cleared
Summary: OptionsPanelController.handleSuccessfulSearch not invoked when search text cl...
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Options&Settings (show other bugs)
Version: 7.3
Hardware: PC Linux
: P2 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 09:07 UTC by Jan Lahoda
Modified: 2012-10-26 01:29 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2012-10-25 09:07:08 UTC
[recent trunk build]

When I type something into the Options' dialog "Search" field and press enter (why press enter, BTW? Would be much more convenient to do filtering as the user types.), my OptionsPanelController.handleSuccessfulSearch is called if appropriate, and does some filtering inside the panel. But when I clear the field and press enter again, my OptionsPanelController.handleSuccessfulSearch is not called, and so it cannot undo the filtering. Please either call the method also when the search field is empty, or introduce a new method that would be called in such a case.
Comment 1 Theofanis Oikonomou 2012-10-25 09:57:01 UTC
(In reply to comment #0)
> [recent trunk build]
> 
> When I type something into the Options' dialog "Search" field and press enter
> (why press enter, BTW? Would be much more convenient to do filtering as the
> user types.), 

It was implemented that way at first, but in was thought to be annoying so changed it to the current behaviour. See comment 8 in bug 216474 for discussion.

> my OptionsPanelController.handleSuccessfulSearch is called if
> appropriate, and does some filtering inside the panel. But when I clear the
> field and press enter again, my OptionsPanelController.handleSuccessfulSearch
> is not called, and so it cannot undo the filtering. Please either call the
> method also when the search field is empty, or introduce a new method that
> would be called in such a case.

good catch, thank you. Calling the same method with null as parameters. Fixed: http://hg.netbeans.org/core-main/rev/f4bcbef4177a
Comment 2 Quality Engineering 2012-10-26 01:29:39 UTC
Integrated into 'main-golden', will be available in build *201210260001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/f4bcbef4177a
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Issue #220816 - OptionsPanelController.handleSuccessfulSearch not invoked when search text cleared