This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 231448 - Patch for: [Options] labels manual proxy should be disabled too
Summary: Patch for: [Options] labels manual proxy should be disabled too
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Options&Settings (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords: PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-06-18 14:01 UTC by markiewb
Modified: 2013-07-01 22:27 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Shows the issue (70.63 KB, image/png)
2013-06-18 14:01 UTC, markiewb
Details
Proposed patch (4.31 KB, patch)
2013-06-19 15:41 UTC, markiewb
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-06-18 14:01:20 UTC
[ BUILD # : 74beta ]
[ JDK VERSION : 1.7.0_21 ]

* Options|General
* Choose use system proxy

ACTUAL: labels 'HTTP proxy' and 'Port' are enabled - see screenshot
EXPECTED: labels 'HTTP proxy' and 'Port' are enabled only if the corresponding
radio button is chosen
Comment 1 markiewb 2013-06-18 14:01:40 UTC
Created attachment 135972 [details]
Shows the issue
Comment 2 markiewb 2013-06-19 15:41:27 UTC
Created attachment 136042 [details]
Proposed patch

I like to propose a patch to solve this issue. The patch 
* enables/disables labels of the manual proxy controls regarding to the checked state of its radio button
* adds missing mnemonics for several labels
* adds usability when checking the manual proxy radio button: the hostname control is focused after selecting the radio button (the user chooses the mode and can type immediately)

@NB-Dev: Please review and commit if appropriate.
Comment 3 Theofanis Oikonomou 2013-06-26 16:05:45 UTC
Thank you for the patch. P3 due to mnemonics. I found more cases of such behavior and I am not aware if there is a common practice for this. I think that the correct behavior should be to disable also the labels though. Fixed: http://hg.netbeans.org/core-main/rev/c26aa1a9617d
Comment 4 Quality Engineering 2013-06-28 02:16:54 UTC
Integrated into 'main-silver', will be available in build *201306272300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c26aa1a9617d
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: #231448 - Patch for: [Options] labels manual proxy should be disabled too
Comment 5 markiewb 2013-07-01 22:27:50 UTC
Verified in 201307011244