This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Development build #200207150340 of NetBeans 3.4 Windows 2000 with JDK 1.4.1 RC build #16 Description: ============ There are some A11Y issues with standard 4-tabbed output window of VCS commands, result window of "Annotate" command and dialog allowing to save the output to a file. Take a look at the attached result files of A11Y tool for the details. I would also like to ask you to setup proper accessible name and descriptions correctly in verification dialog of VCS groups.
Created attachment 6671 [details] A11Y problems in result window of Annotate command.
Created attachment 6672 [details] A11Y problems in standard output window.
Created attachment 6673 [details] A11Y problems in save-to-file dialog.
Created attachment 6674 [details] A11Y problems in VCS group verification window.
This is accessibility issue.
*** Issue 25668 has been marked as a duplicate of this issue. ***
Problems in the standard output window fixed in the main trunk with these exceptions: - no accessibility defined for scroll bars, - no LABEL_FOR pointing to javax.swing.JTabbedPane and javax.swing.JTextArea - not necessary - no mnemonics for Close button - it's the default button, that is activated by ENTER - does not have to have mnemonic.
Diffs of the standard output window: http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/commands/Bundle.properties.diff?r1=1.19&r2=1.20 http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/commands/CommandOutputVisualizer.java.diff?r1=1.15&r2=1.16 http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/commands/CommandOutputPanel.java.diff?r1=1.15&r2=1.16 Problems in result window of Annotate command fixed in the main trunk with these exceptions: - no accessibility defined for scroll bars, - no LABEL_FOR pointing to javax.swing.JTable and org.netbeans.core.windows.frames.CloseButtonTabbedPane - not necessary Diffs: http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/ui/Bundle.properties.diff?r1=1.7&r2=1.8 http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/ui/AnnotatePanel.java.diff?r1=1.6&r2=1.7
Fixed mnemonics and accessibility problems in save-to-file dialog in the main trunk. All reported problems should be fixed. Diffs: http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/commands/Bundle.properties.diff?r1=1.20&r2=1.21 http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/commands/SaveToFilePanel.java.diff?r1=1.2&r2=1.3
The accessibility problems in VCS group verification window fixed for all "Do Add", "Do Update" and "Not Changed" panels with the exception of no LABEL_FOR pointing to javax.swing.JTable and javax.swing.JTextArea -- it's not necessary. Accessible description of javax.swing.JButton { Correct Group | } set in vcsgeneric module for CVS, PVCS and VSS integration. In JavaCVS it's already set. Diffs: http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/ui/Bundle.properties.diff?r1=1.8&r2=1.9 http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/ui/NotChangedFilesPanel.java.diff?r1=1.4&r2=1.5 http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/ui/ToAddFilesPanel.java.diff?r1=1.2&r2=1.3 http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/ui/ToUpdateFilesPanel.java.diff?r1=1.2&r2=1.3 http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/Bundle.properties.diff?r1=1.3&r2=1.4 http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsVerifyAction.java.diff?r1=1.1&r2=1.2 http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/commands/Bundle.properties.diff?r1=1.8&r2=1.9 http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/commands/PvcsVerifyAction.java.diff?r1=1.1&r2=1.2 http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/vss/src/org/netbeans/modules/vcs/profiles/vss/commands/Bundle.properties.diff?r1=1.1&r2=1.2 http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/vss/src/org/netbeans/modules/vcs/profiles/vss/commands/VssVerifyAction.java.diff?r1=1.1&r2=1.2
Changed files verified for 3.4 integration.
Additional type mistake corrected. Diff: http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/ui/Bundle.properties.diff?r1=1.9&r2=1.10
Merged into release34 branch.
OK, in NB40dev-2002-1108-0100 Well, most probably this issue seems fixed well, but there are slight differences (worse for gcvs) agains javacvs: *Annotation* output has No Accessible description : Class: org.netbeans.core.windows.frames.TopFrameTypeImpl { Output of VCS Commands [Annotate build.xml] | } is it right Martin?
Well, I've probably forgot about accessible description for the annotate window title. Reopening...
Adjusting Target Milestone to 4.0 then.
Thank you Martin:-) I know you'are bussy with implementataing new projects, so lowerising the priority to P4;-)
Accessibility issue - needs to be solved into 3.5.
Fixed. problem with 'Components with no LABEL_FOR pointing to it' - as designed. Problem with 'tab traversal' and 'mnemonics conflict' is irrelevant - bug in test tool. =============================================== Tested Window title : CVS Output [Annotate ControlLabel.form] =============================================== Results of Accessibility test Doesn't implement Accessible : - none. No Accessible name : Class: javax.swing.JScrollPane$ScrollBar { | } No Accessible description : Class: javax.swing.JScrollPane$ScrollBar { | } Label with LABEL_FOR not set : - none. Components with no LABEL_FOR pointing to it : Class: javax.swing.JTable { Table of File Annotations | N/A } Components with no mnemonic : - none. Components with wrong mnemonic (mnemonic isn't ASCII , label doesn't contain mnemonic): - none. Components with potential mnemonics conflict: - components with mnemonic 'R' : Class: javax.swing.JLabel { Filter Revision: | } Class: javax.swing.JLabel { Filter Revision: | } - components with mnemonic 'F' : Class: javax.swing.JLabel { Filename: | } Class: javax.swing.JLabel { Filename: | } - components with mnemonic 'A' : Class: javax.swing.JLabel { Filter by Author: | } Class: javax.swing.JLabel { Filter by Author: | } Components not reachable with tab traversal : Class: javax.swing.JComboBox { Select author | N/A } Class: javax.swing.JComboBox { Select revision | N/A } Class: javax.swing.JScrollPane$ScrollBar { | } Class: javax.swing.JTable { Table of File Annotations | N/A }
I am sorry for reopening this issue but it is still not good. Please look at accessible description of the annotate window invoked using command-line (not built-in !) CVS client. Trying to verify in NetBeans 3.5.1 build #200307092351.
OK, you are right. I got test on javacvs annotate cmd.There is problem in cmdline cvs annotate cmd. Created TopComponent doesn't take description from its panel.
Created attachment 10977 [details] diff of propsed changes
Fixed in trunk. Checking in src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsAnnotate.java; /cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsAnnotate.java,v <-- CvsAnnotate.java new revision: 1.5; previous revision: 1.4 done
Excellent, verified in development build #200307160100 of NetBeans 4.0.
Bugfix merged to prj40_prototype branch so that it will survive after projects branch will be put into the main trunk. /cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsAnnotate.java,v <-- CvsAnnotate.java new revision: 1.4.6.1; previous revision: 1.4