This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 26136 - Mistake in API introduction (public access modifier instead of protected).
Summary: Mistake in API introduction (public access modifier instead of protected).
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Text (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: Peter Zavadsky
URL:
Keywords: API
Depends on:
Blocks:
 
Reported: 2002-07-31 09:54 UTC by Peter Zavadsky
Modified: 2008-12-22 20:29 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Patch (750 bytes, patch)
2002-07-31 14:21 UTC, Peter Zavadsky 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Zavadsky 2002-07-31 09:54:59 UTC 
There is introduced new API in 3.4,
Specifically in TopComponent two protected methods:
componentShowing, and componetnHidden

Problem is in CloneableEditor (subclass of
TopComponent), the component showing method is
overriden the way:

public void componentShowing() ...

instead of:

protected void componentShowing() ...



Is it possible to make the change into 3.4?
Comment 1 Peter Zavadsky 2002-07-31 14:21:52 UTC 
Created attachment 6962 [details]
Patch
Comment 2 Peter Zavadsky 2002-07-31 14:25:22 UTC 
I want to point out, I cannot apply the patch just into [trunk], since
the method is introduced first time just in [release34].
Comment 3 Jaroslav Tulach 2002-07-31 16:02:37 UTC 
Well, this looks like really serious mistake and thank you Peter for
finding this before we got to FCS.

The problem is that if we does not fix the bug now, it will appear in
a release and becase we want to keep the API compatible, it will stay
there forever.

The fix is simple and verification of all possible regressions also -
if we can compile NetBeans, than there is no regression. That is why I
approve that fix suggest others to also do so.
Comment 4 Jesse Glick 2002-07-31 17:26:44 UTC 
I agree, this is important to fix before release.
Comment 5 Peter Zavadsky 2002-08-01 14:38:28 UTC 
Fixed in both [trunk] and [release34]

trunk:
openide/../text/CloneableEditor.java [1.47]

release34:
openide/../text/CloneableEditor.java [1.42.16.2]
Comment 6 Jesse Glick 2002-08-01 14:49:48 UTC 
x
Comment 7 Jesse Glick 2002-08-01 14:50:14 UTC 
Was resolved with no resolution.
Comment 8 Marian Mirilovic 2002-08-09 13:10:23 UTC 
verified in [nb_release34_rc2](20020809)
Comment 9 Quality Engineering 2003-07-01 16:37:37 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.