This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
WizardDescriptor.Panel implementation org\netbeans\modules\jarpackager\wizard\ContentMemberPanel.java provides itself as the result of getComponent(). This hurts performance and can cause a clash when Component.isValid() is overridden. Please use a separate component class, see details at http://performance.netbeans.org/howto/dialogs/wizard-panels.html. Easy to fix, P2 justification - performance is top priority.
Similar situation is for org\netbeans\modules\jarpackager\wizard\ManifestWizardPanel.java org\netbeans\modules\jarpackager\wizard\PropertyEditorPanel.java Please fix them as well.
Oh my oh my, please ignore my last comment, I didn't study the code well enough. Mentioned classes are ok I think.
The UI will be reimplemented for 4.0. The classes will be replaced.
Ok, but then please pay attention to not repeat such mistake again. I recommend to leave one of these bugs open, perhaps with lower priority as "watchdog" and close it after new design will be done so that I can come and check performance again. Or make up some other way how to notify me, please. Thx.
Reopening, according to the discussion in nb perf team. Justification: The bug *currently* exists. There is no need to fix it in older version if new version of UI will obsolete or fix this issue. But correct is to close the bug at the time when new impl will be in trunk, not earlier. Thx.
Fixed. Done for all wizard panels in wizard package.
Guys, there was an error in example code in IDESettingsWizardPanel.java. Please check your fix and repair if you did the same mistake. I'm terribly sorry, but I'm only a human :-) Please read details below: --------------------------------- Modified: src/org/netbeans/core/ui IDESettingsWizardPanel.java Log: fix for incorrect assumption that getComponent must be called before readSettings. Now they can be called in any order. Revision Changes Path 1.3 +2 -2 core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java http://core.netbeans.org/source/browse/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java.diff?r1=1.2&r2=1.3 (In the diff below, changes in quantity of whitespace are not shown.) Index: IDESettingsWizardPanel.java =================================================================== RCS file: /cvs/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -b -r1.2 -r1.3 --- IDESettingsWizardPanel.java 2002/12/03 14:10:35 1.2 +++ IDESettingsWizardPanel.java 2003/01/24 13:45:30 1.3 @@ -7,7 +7,7 @@ * http://www.sun.com/ * * The Original Code is NetBeans. The Initial Developer of the Original - * Code is Sun Microsystems, Inc. Portions Copyright 1997-2001 Sun + * Code is Sun Microsystems, Inc. Portions Copyright 1997-2003 Sun * Microsystems, Inc. All Rights Reserved. */ @@ -42,7 +42,7 @@ */ public void readSettings (Object settings) { if (settings instanceof WizardDescriptor) { - panelUI.initFromSettings((WizardDescriptor)settings); + getPanelUI().initFromSettings((WizardDescriptor)settings); } }
verified