This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
WizardDescriptor.Panel implementation org\netbeans\modules\vcscore\wizard\mountcvs\AbstractWizardPanel.java provides itself as the result of getComponent(). This hurts performance and can cause a clash when Component.isValid() is overridden. Please use a separate component class, see details at http://performance.netbeans.org/howto/dialogs/wizard-panels.html. Easy to fix, P2 justification - performance is top priority.
Richard Gregor already made the improvements in the vcsgeneric module org\netbeans\modules\vcs\advanced\wizard\mount\AbstractWizardPanel.java The CVS mount wizard in vcscore will probably be removed completely. I'm leaving this opened for now, but close as soon as the common CVS mount wizard is removed.
*** Issue 29964 has been marked as a duplicate of this issue. ***
It will have to be fixed in the main trunk (not for NB4.0, but for S1S 4.2).
Fixed in the main trunk. /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/CMPanel.java,v <-- CMPanel.java new revision: 1.28; previous revision: 1.27 /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/CheckoutPanel.java,v <-- CheckoutPanel.java new revision: 1.14; previous revision: 1.13 /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/ClientPanel.java,v <-- ClientPanel.java new revision: 1.22; previous revision: 1.21 /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/CvsHomePanel.java,v <-- CvsHomePanel.java new revision: 1.17; previous revision: 1.16 /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/LoginPanel.java,v <-- LoginPanel.java new revision: 1.22; previous revision: 1.21 /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/MountCvsWizard.java,v <-- MountCvsWizard.java new revision: 1.17; previous revision: 1.16 /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/RMPanel.java,v <-- RMPanel.java new revision: 1.21; previous revision: 1.20 /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/WDPanel.java,v <-- WDPanel.java new revision: 1.35; previous revision: 1.34 RCS file: /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/GenericWizardPanel.java,v /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/GenericWizardPanel.java,v <-- GenericWizardPanel.java initial revision: 1.1 Removing vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/AbstractWizardPanel.java; /cvs/vcscore/src/org/netbeans/modules/vcscore/wizard/mountcvs/AbstractWizardPanel.java,v <-- AbstractWizardPanel.java new revision: delete; previous revision: 1.5
Guys, there was an error in example code in IDESettingsWizardPanel.java. Please check your fix and repair if you did the same mistake. I'm terribly sorry, but I'm only a human :-) Please read details below: --------------------------------- Modified: src/org/netbeans/core/ui IDESettingsWizardPanel.java Log: fix for incorrect assumption that getComponent must be called before readSettings. Now they can be called in any order. Revision Changes Path 1.3 +2 -2 core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java http://core.netbeans.org/source/browse/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java.diff?r1=1.2&r2=1.3 (In the diff below, changes in quantity of whitespace are not shown.) Index: IDESettingsWizardPanel.java =================================================================== RCS file: /cvs/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -b -r1.2 -r1.3 --- IDESettingsWizardPanel.java 2002/12/03 14:10:35 1.2 +++ IDESettingsWizardPanel.java 2003/01/24 13:45:30 1.3 @@ -7,7 +7,7 @@ * http://www.sun.com/ * * The Original Code is NetBeans. The Initial Developer of the Original - * Code is Sun Microsystems, Inc. Portions Copyright 1997-2001 Sun + * Code is Sun Microsystems, Inc. Portions Copyright 1997-2003 Sun * Microsystems, Inc. All Rights Reserved. */ @@ -42,7 +42,7 @@ */ public void readSettings (Object settings) { if (settings instanceof WizardDescriptor) { - panelUI.initFromSettings((WizardDescriptor)settings); + getPanelUI().initFromSettings((WizardDescriptor)settings); } }
That's OK Dafe, The bug was finaly fixed. What's the surprise, isn't it? ;-))) But I don't feel like to verify this issue. Would you mind to verify it, please? Of'course after MArtin will say that he believe in his fixed or repair it along your new description ;-) Thanx -Dan
I've went through the changes in vcsgeneric and vcscore. The bug from IDESettingsWizardPanel is not present there. So I hope, that the fix is O.K.
I hope this time Dafe is satisfied. Thus verifying instead of him. If you disagree, don't hesitate to reopen it. Verified in NetBeans 3.5.1 build #200307092351.