This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 29143 - avoid keeping static references to resource bundles
Summary: avoid keeping static references to resource bundles
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Martin Entlicher
URL: http://www.netbeans.org/download/dev/...
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2002-11-28 15:52 UTC by _ rkubacki
Modified: 2003-12-11 14:27 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2002-11-28 15:52:36 UTC
These resources cannot be released and sometimes
are initialized even when it is not neceseary.
Comment 1 Martin Entlicher 2002-11-28 16:14:21 UTC
This is more a problem connected to performance, than a defect in
functionality - changing to TASK if you don't mind.

This problem needs to be addressed in all VCS modules - so changing
the component to vcscore (a "core" part of VCS modules).
Comment 2 _ rkubacki 2002-11-28 16:28:03 UTC
I don't mind if you commit to fix it for next release.
Comment 3 Martin Entlicher 2002-11-28 16:37:53 UTC
O.K. Changing TM to 4.0.
Comment 4 Martin Entlicher 2003-08-01 13:36:57 UTC
Starting to search for the static references...
Comment 5 Martin Entlicher 2003-08-01 14:14:28 UTC
Fixed for vcscore module:

Checking in annotation/AnnotVariablePropertyEditor.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/annotation/AnnotVariablePropertyEditor.java,v 
<--  AnnotVariablePropertyEditor.java
new revision: 1.1.110.1; previous revision: 1.1
done
Processing log script arguments...
More commits to come...
Checking in grouping/AutoAdditionPropertyEditor.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/grouping/AutoAdditionPropertyEditor.java,v 
<--  AutoAdditionPropertyEditor.java
new revision: 1.2.110.1; previous revision: 1.2
done
Processing log script arguments...
More commits to come...
Checking in ui/views/types/LogInfoPanel.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/views/types/LogInfoPanel.java,v 
<--  LogInfoPanel.java
new revision: 1.1.72.2; previous revision: 1.1.72.1
done
Checking in ui/views/types/StatusInfoPanel.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/views/types/StatusInfoPanel.java,v 
<--  StatusInfoPanel.java
new revision: 1.1.72.2; previous revision: 1.1.72.1
done
Checking in ui/views/types/UpdateStdOutPanel.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/views/types/UpdateStdOutPanel.java,v 
<--  UpdateStdOutPanel.java
new revision: 1.1.72.1; previous revision: 1.1
done
Processing log script arguments...
More commits to come...
Checking in settings/RefreshModePropertyEditor.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/settings/RefreshModePropertyEditor.java,v 
<--  RefreshModePropertyEditor.java
new revision: 1.2.110.1; previous revision: 1.2
done
Processing log script arguments...
More commits to come...
Checking in ui/fsmanager/VcsManager.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/fsmanager/Attic/VcsManager.java,v 
<--  VcsManager.java
new revision: 1.1.2.9; previous revision: 1.1.2.8
done
Checking in ui/fsmanager/VcsManager.form;
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/fsmanager/Attic/VcsManager.form,v 
<--  VcsManager.form
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in VcsFSCommandsAction.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/VcsFSCommandsAction.java,v 
<--  VcsFSCommandsAction.java
new revision: 1.2.4.2; previous revision: 1.2.4.1
done
Comment 6 Martin Entlicher 2003-08-01 14:27:14 UTC
Fixed in vcsgeneric module and it's sub-modules:

Checking in CommandLineVcsFileSystem.java;
/cvs/vcsgeneric/src/org/netbeans/modules/vcs/advanced/CommandLineVcsFileSystem.java,v 
<--  CommandLineVcsFileSystem.java
new revision: 1.128.4.10; previous revision: 1.128.4.9
done
Checking in log/LogInfoPanel.java;
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/log/Attic/LogInfoPanel.java,v 
<--  LogInfoPanel.java
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Processing log script arguments...
More commits to come...
Checking in status/StatusInfoPanel.java;
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/status/Attic/StatusInfoPanel.java,v 
<--  StatusInfoPanel.java
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Comment 7 Martin Entlicher 2003-08-01 14:30:13 UTC
Diff does not have any static references to resource bundles.
Resolving as fixed. Fixed only in projects branch.

To find the static references following regular expression was used:
^.*static.*Bundle.*$
Comment 8 Jiri Kovalsky 2003-08-07 16:41:26 UTC
Radime, can you please verify that the references were indeed removed
? Thanks !
Comment 9 _ rkubacki 2003-09-15 09:39:41 UTC
Yet there are some in vcsgeneric and javacvs. I don't know if these
are really built or not. 
vcsgeneric

filessupport.src.org.netbeans.modules.vcs.profilessupport.commands.log.LogInfoPanel
[439]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
vcsgeneric.profilessupport.src.org.netbeans.modules.vcs.profilessupport.commands.status.StatusInfoPanel
[439]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')

javacvs 

javacvs.changelog.src.org.netbeans.modules.changelog.settings.DefaultServerInfoPE
[27]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.ToolsCvsExecutionPanel
[348]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.add.AddInfoPanel
[169]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.checkout.NbCheckoutParamInput
[564]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.commit.CommitInfoPanel
[180]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.commit.NbSimpleCommitParamInput
[159]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.log.LogInfoPanel
[491]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.remove.RemoveInfoPanel
[170]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.status.StatusInfoPanel
[457]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.tag.NbSimpleTagParamInput
[153]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.update.UpdateInfoPanel
[193]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.commands.update.UpdateStdOutPanel
[172]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.customizer.Cust1WorkPanel
[40]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle1')
javacvs.src.org.netbeans.modules.cvsclient.customizer.Cust1WorkPanel
[41]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle2')
javacvs.src.org.netbeans.modules.cvsclient.customizer.Cust1WorkPanel
[280]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.customizer.Cust2ServerPanel
[467]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.customizer.LoginDialog
[356]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.customizer.NbJavaCvsCustomizer
[147]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.editors.DisplayTypePropertyEditor
[30]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.editors.StatesStringArrayCustomEditor
[392]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.cvsclient.editors.UiModePropertyEditor
[30]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.AddParamInput
[304]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.AnnotateParamInput
[322]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.CheckoutParamInput
[486]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.CommitParamInput
[422]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.DiffParamInput
[362]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.ExportParamInput
[550]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.GlobalOptionsCustomizer
[143]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.HistoryParamInput
[576]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.ImportParamInput
[416]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.LogParamInput
[437]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.RemoveParamInput
[165]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.StatusParamInput
[161]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.TagParamInput
[389]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.UpdateParamInput
[612]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.customizers.WatchersParamInput
[149]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.editors.KeywordSubstitutionPropertyEditor
[32]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')
javacvs.src.org.netbeans.modules.javacvs.editors.RefreshModePropertyEditor
[30]: BadBundleCode, Avoid static references to ResourceBundles
(variable 'bundle')


Comment 10 Martin Entlicher 2003-09-15 13:01:18 UTC
profilessupport sub-module is dead. It will be removed as soon as
Richard finish the transfer of UI from profilessupport to cvsprofile.

It was not fixed in javacvs probably because javacvs module will not
be a part of NetBeans 4.0 anyway. I've created issue #36086 for
javacvs, it may never be fixed.
Comment 11 _ rkubacki 2003-09-15 13:09:26 UTC
OK.