This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 44321 - LocationPanel for empty tests does not reuse standard Java target chooser
Summary: LocationPanel for empty tests does not reuse standard Java target chooser
Status: CLOSED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: JUnit (show other bugs)
Version: 4.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: junit-issues@java
URL:
Keywords:
Depends on: 44506
Blocks: 42589
  Show dependency tree
 
Reported: 2004-06-04 00:43 UTC by Jesse Glick
Modified: 2006-03-24 09:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-06-04 00:43:13 UTC
040603. I noticed that the target chooser does not
work correctly when

-J-Dorg.netbeans.spi.java.project.support.ui.packageView.TRUNCATE_PACKAGE_NAMES=true

is used. This bug existed in the original Java
target chooser, which you maybe copied, and was
fixed since.

You should be using
JavaTemplates.createPackageChooser with the
bottomPanel parameter to avoid code duplication.
Specifically LocationPanel.setupPackageChooser is
incorrectly using node.displayName.
Comment 1 Marian Petras 2004-06-15 16:42:18 UTC
Accepted.
Comment 2 Marian Petras 2004-06-15 19:05:23 UTC
fixed in the trunk (together with bugs #43621, #44202, #44051, #44318,
#44320)

changed files:

junit/src/org/netbeans/modules/junit/wizards/Bundle.properties   (1.3)
junit/src/org/netbeans/modules/junit/wizards/EmptyTestCaseWizardIterator.java
  (1.5)
junit/src/org/netbeans/modules/junit/wizards/EmptyTestStepLocation.java
  (1.4)
junit/src/org/netbeans/modules/junit/wizards/LocationPanel.java  
(deleted - last revision 1.3)
junit/src/org/netbeans/modules/junit/wizards/SimpleTestStepLocation.java
  (1.5)
junit/src/org/netbeans/modules/junit/wizards/StepProblemMessage.java 
 (1.1 - initial revision)
junit/src/org/netbeans/modules/junit/wizards/TestSuiteStepLocation.java
  (1.4)
junit/src/org/netbeans/modules/junit/wizards/TestSuiteWizardIterator.java
  (1.5)
junit/src/org/netbeans/modules/junit/wizards/Utils.java   (1.5)
Comment 3 dmladek 2004-06-16 11:34:03 UTC
ufff... Jesse would you mind to verify this issue, please?
Thanks
-dan
Comment 4 Marian Petras 2004-06-16 12:59:35 UTC
Information:

LocationPanel is not used any more (and has been removed from the
source base). The standard Java target chooser is used in wizards
"Empty Test" and "Test Suite". The corresponding Java classes are:

  org.netbeans.modules.junit.wizards.EmptyTestStepLocation
  org.netbeans.modules.junit.wizards.TestSuiteStepLocation

Wizard "Test for Existing Class" does not use the standard Java target
chooser and I do not plan to change it.
Comment 5 Jesse Glick 2004-06-21 19:10:58 UTC
Don't see any problems in 040619.