This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 45767 - No indication of Refresh Revisions action in Versioning tab
Summary: No indication of Refresh Revisions action in Versioning tab
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 4.x
Hardware: PC All
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2004-06-30 17:13 UTC by Antonin Nebuzelsky
Modified: 2006-03-24 09:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2004-06-30 17:13:34 UTC 
If you expand a java class node in Versioning tab,
you see "Please wait..." node until the list of
revisions is retrieved from server. But if you
invoke Refresh Revisions on an expanded node,
nothing seems to be happening.

This is a UI responsiveness problem and should be
solved by replacing the nodes of revisions with
"Please wait..." node until the updated set of
revisions is available.
Comment 1 Martin Entlicher 2004-07-08 10:19:39 UTC 
O.K., this should not be hard to do. Starting to work on it...
Comment 2 Martin Entlicher 2004-07-08 10:49:02 UTC 
Fixed in trunk:

/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/impl/VersioningDataNode.java,v
 <--  VersioningDataNode.java
new revision: 1.11; previous revision: 1.10

/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionChildren.java,v
 <--  RevisionChildren.java
new revision: 1.7; previous revision: 1.6
Comment 3 Antonin Nebuzelsky 2004-07-08 14:52:05 UTC 
Looks good for one operation at a time. But still not responsive as it
should be if some revision retrieval is already in progress. The
refresh revisions action starts only after the action in progress is
finished. Only then the "please wait..." node is displayed.
Comment 4 Martin Entlicher 2004-07-08 15:39:31 UTC 
The problem is, that there is used a special private RequestProcessor,
that serializes all tasks. The default parallel RequestProcessor needs
to be used, with some light synchronization where necessary.
Comment 5 Martin Entlicher 2004-07-08 16:24:15 UTC 
Fixed. Hopefully it's O.K. now.

/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/impl/VersioningDataNode.java,v
 <--  VersioningDataNode.java
new revision: 1.12; previous revision: 1.11
Comment 6 Antonin Nebuzelsky 2004-07-09 09:58:42 UTC 
Works nicely now.