This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 52536 - Status command output and filtering runs in AWT thread
Summary: Status command output and filtering runs in AWT thread
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2004-12-16 08:57 UTC by _ rkubacki
Modified: 2005-04-13 18:54 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2004-12-16 08:57:26 UTC
build 200412141900, JDK 5.0-b64

I noticed this when checked out netbeans
repository and executed status on its root. Calls
from OutputVisualiser.open propagate into
CvsListOffline.loadEntries and deeper where it
waits for I/O operation.

When the result is displayed there are again
similar problems with freezing UI. Filtering of
statuses is done in AWT thread so my screen is not
repainted for 20 seconds (PIII/800MHz/512MB).
Comment 1 Martin Entlicher 2004-12-16 10:30:49 UTC
Will check the behavior, moving to vcsgeneric module where the
visualizer is implemented.
Comment 2 Martin Entlicher 2005-01-10 13:02:17 UTC
This can not be reproduced on small working directories (like single
NB module - vcscore).

The problem was reproduced on all NB sources.

The core of the problem is, that not all data can be obtained from the
output of the command. We need to find some suitable place where to
put the access to CVS/Entries...

The problem with freezing UI when filtering statuses can be solved by
changing the cursor to WAIT cursor and do the filtering asynchronously.
Comment 3 Martin Entlicher 2005-01-10 13:32:51 UTC
The problem also is, that the *whole* tree is created even though only
a few nodes are expanded. This is an extra optimization, that should
be done for all recursive views.
Comment 4 Martin Entlicher 2005-01-10 16:57:36 UTC
Fixed in trunk:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/status/CvsStatusVisualizer.java,v
 <--  CvsStatusVisualizer.java
new revision: 1.14; previous revision: 1.13

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/status/StatusInformation.java,v
 <--  StatusInformation.java
new revision: 1.8; previous revision: 1.7

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/status/StatusTreeInfoPanel.java,v
 <--  StatusTreeInfoPanel.java
new revision: 1.7; previous revision: 1.6
Comment 5 _ rkubacki 2005-04-13 13:45:50 UTC
I tried it again and for a while I saw tree containing nodes - 'colors',
'sports' & 'foods' and some leafs under these + wrong label for the tree component.
Comment 6 Martin Entlicher 2005-04-13 17:58:22 UTC
The original performance problem was already fixed in 4.1.
This is a sort of functional bug, that is similar to issue #55363.

What we can do for 4.1, is to replace the default funny tree with some "Please
Wait" node.
Comment 7 Martin Entlicher 2005-04-13 18:48:41 UTC
I would rather have that as a separate issue. It's definitely not P2, the
original performance problem was solved. This is a funny functional problem, at
most P3 IMHO. In real cases the funny nodes remains there for a very short time.

Marking as FIXED again.
Comment 8 Martin Entlicher 2005-04-13 18:54:28 UTC
See issue #57850.