This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 55143 - CVS: Performance problem during commit
Summary: CVS: Performance problem during commit
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2005-02-17 16:07 UTC by Martin Entlicher
Modified: 2005-02-18 17:25 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2005-02-17 16:07:41 UTC 
Before commit is executed, all working
subdirectory that is being committed is scanned
and a map of repository paths and appropriate
working directories is built. This is used to be
able to refresh the status of appropriate files
after commit is done.

However, this impose a performance problem,
because the scanning takes some time.

When the built-in client is used, or command-line
on JDK 1.5, we can merge the output streams and
parse the output more easily and reliably.
Comment 1 Martin Entlicher 2005-02-17 17:22:59 UTC 
Fixed in trunk:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvs.xml,v
 <--  cvs.xml
new revision: 1.146; previous revision: 1.145

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCommit.java,v
 <--  CvsCommit.java
new revision: 1.25; previous revision: 1.24

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCommit.java,v
 <--  CvsCommit.java
new revision: 1.26; previous revision: 1.25
Comment 2 Martin Entlicher 2005-02-18 11:08:04 UTC 
The fix was reverted back. "Examining ..." strings sent from the
server can not be used to locate the committed files (unlike all other
CVS commands).

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCommit.java,v
 <--  CvsCommit.java
new revision: 1.27; previous revision: 1.26

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvs.xml,v
 <--  cvs.xml
new revision: 1.147; previous revision: 1.146
Comment 3 Martin Entlicher 2005-02-18 16:01:33 UTC 
A better fix's in:

/cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/ExecuteCommand.java,v
 <--  ExecuteCommand.java
new revision: 1.89; previous revision: 1.88

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCommit.java,v
 <--  CvsCommit.java
new revision: 1.28; previous revision: 1.27

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvs.xml,v
 <--  cvs.xml
new revision: 1.148; previous revision: 1.147
Comment 4 Martin Entlicher 2005-02-18 17:24:50 UTC 
One more change that assures the desired performance is in:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCommit.java,v
 <--  CvsCommit.java
new revision: 1.29; previous revision: 1.28