This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 56047 - PVCS: Add All is slow
Summary: PVCS: Add All is slow
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2005-03-07 10:07 UTC by Martin Entlicher
Modified: 2005-04-01 15:57 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2005-03-07 10:07:00 UTC 
Add All command process the sources directory by
directory, which is slow. The reason for the
current implementation was, that it's not desired
to add all files that are under the added folder
(we should skip backups, not-sharable files,
etc.), but PVCS does not have any concept of
ignored files. Therefore we could not use -z
option to efficiently add all files at once.

The current implementation is correct, but slow.
Comment 1 Martin Entlicher 2005-03-07 10:09:26 UTC 
Scheduling for 4.1.
It actually could be speed up, if we isolate files that are to be
added and the rest into separate directories. This approach is more
error-prone, but will hopefully be faster.
Comment 2 Martin Entlicher 2005-03-07 12:54:53 UTC 
Fixed as proposed. The overall Add All (add + refresh rec.) seems to
be faster by ~33%. The Add All itself (without refresh) is faster by
more then 50%.

/cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java,v
 <--  UserCommandTask.java
new revision: 1.40; previous revision: 1.39

/cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java,v
 <--  UserCommandTask.java
new revision: 1.41; previous revision: 1.40

/cvs/vcsgeneric/src/org/netbeans/modules/vcs/profiles/commands/RecursiveFolderCommand.java,v
 <--  RecursiveFolderCommand.java
new revision: 1.24; previous revision: 1.23

RCS file:
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/commands/MoveFilesNotToAdd.java,v

/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/commands/MoveFilesNotToAdd.java,v
 <--  MoveFilesNotToAdd.java
initial revision: 1.1

/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcs.xml,v
 <--  pvcs.xml
new revision: 1.47; previous revision: 1.46