This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 62900 - Go To menu mnemonic does not work
Summary: Go To menu mnemonic does not work
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: David Simonek
URL: http://ui.netbeans.org/nonav/docs/hi/...
Keywords: A11Y, UI
: 65710 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-08-24 00:49 UTC by Jesse Glick
Modified: 2008-12-22 20:30 UTC (History)
11 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2005-08-24 00:49:57 UTC
If a Java source file is open in the editor, the mnemonic 'G' for the "Go To"
menu does not work, since Alt-G is bound to [Go To] Declaration.

Should either choose a different keybinding for this action or a different
mnemonic for the menu.
Comment 1 David Simonek 2005-09-01 13:10:02 UTC
Fixed in main trunk:
Checking in Bundle.properties;
/cvs/core/src/org/netbeans/core/Bundle.properties,v  <--  Bundle.properties
new revision: 1.410; previous revision: 1.409

But now mnemonic for GoTo is T, mnemonic for Tools is L, which is not very nice.
Maybe some editor shortcuts revision would be better?
Comment 2 Jesse Glick 2005-09-01 17:51:16 UTC
I think this is pretty ugly too. Every other app I can think of uses T as the
mnemonic for Tools.

IMHO the app should never bind Alt-<letter> for any keyboard shortcut - reserve
these for mnemonics. But it's a big change for anyone used to using the NB
editor's key bindings.
Comment 3 David Simonek 2005-09-02 09:12:29 UTC
Glad to hear Jesse has the same opinion. Jano, please note this somewhere as it
won't get forgotten during our shortcuts rearranging work (which is planned
anyway I think?)
Comment 4 Jesse Glick 2005-09-21 17:52:34 UTC
I think this fix needs to be reverted or changed. Using L as the mnemonic for
Tools just will not stick in my head - it's been three weeks and I still use
Alt-T every time and am surprised when the Go To menu is displayed.

We should consider just not having *any* mnemonic for the Go To menu. It is
hardly necessary - there is only one menu item in the menu that has no
accelerator: "Recent Document", whatever that does. So if you are a keyboard
user, you just don't invoke this menu very often at all, except a few times when
learning how to use the IDE. By contrast, the Tools menu is full of occasionally
used actions with no accelerators, so as a KB user this is the one menu which
you most frequently invoke via its mnemonic. We should optimize for usage of the
Tools menu over Go To.
Comment 5 jrojcek 2005-09-22 10:53:54 UTC
This is a very good point. I also tend to say that we should rather move back to 'T' for Tools and don't 
use any mnemonic for Go To. We'll have an a11y problem, but I would rather stick with it than moving 
away 'T' from Tools, which seems to be a standard mnemonic in other apps.

Should I reopen this issue?
Comment 6 David Simonek 2005-09-22 11:28:16 UTC
Ok, as you wish my lords. Moreover Alt+L clashes with editor actions anyway
(back or forward action).
Comment 7 David Simonek 2005-09-22 11:36:44 UTC
fixed in main trunk:

Checking in Bundle.properties;
/cvs/core/src/org/netbeans/core/Bundle.properties,v  <--  Bundle.properties
new revision: 1.414; previous revision: 1.413
Comment 8 Antonin Nebuzelsky 2005-09-22 12:25:45 UTC
Sorry guys, I don't agree with Go To having no mnemonic.
Go To / Class.. is the most frequent action I use and I cannot use Alt+Shift+O
for it because I have Shift+Alt mapped to switching between keyboard layouts in
Gnome.
OK, I could change the keyboard switching shortcut to something else, but anyway
top level menu item MUST have a mnemonic. This should be P2 IMHO.
Comment 9 David Simonek 2005-09-22 12:55:04 UTC
Ok, seems like more complicated usability problem, passing directly to Jano.
Comment 10 Jesse Glick 2005-09-22 15:35:45 UTC
Re. Shift-Alt switching KB layouts:

- Is this a standard shortcut on Gnome when you have >1 KB layout, or your own
customization?

- Note that Go To can still be posted via Alt-S Left, though of course it is not
as nice.
Comment 11 Antonin Nebuzelsky 2005-09-23 16:01:57 UTC
> Is this a standard shortcut on Gnome when you have >1 KB layout,
> or your own customization?

OK, I created a test user on my machine, logged in as the test user and tried.
The default shortcut to switch keyboard layouts in my FC3 gnome (gnome 2.8) is
"both alt keys together". Alt+Shift is among the available options you can see
in the list in Preferences.

> ... Go To can still be posted via Alt-S Left ...

First I thought you were joking. :) Well, you are right, it is accessible this
way. But who would use it?? I'd rather grab my mouse and click...

And have a look at the main menu now. It's so ugly without a mnemonic for Go To. ;)
Comment 12 David Simonek 2005-10-03 14:24:41 UTC
*** Issue 65710 has been marked as a duplicate of this issue. ***
Comment 13 Marian Mirilovic 2005-10-03 14:53:23 UTC
Sorry, 
I don't think the main menu without mnemonic is acceptable here. At least from
A11Y point of view. 

What about Alt-O ? 

I've also moved the issue to the core, because issue reported against ide
component are not tracked under NB 5.0 bugcount.

Comment 14 Jesse Glick 2005-10-03 21:57:40 UTC
Alt-O is also taken. (Go to Source)
Comment 15 Antonin Nebuzelsky 2005-10-04 10:10:51 UTC
IMO this is a good reason to rethink all shortcuts we have in Netbeans and do
necessary changes to have ALT+whatever for accessing menu items.

This release will be a major release (5.0), so NOW is the time to do it...
Comment 16 David Simonek 2005-10-05 16:30:45 UTC
We consulted with HIE guys, on nbusability and conclusion fow now is:
Current state will remain in 5.0, issue will be solved by shortcut's general
rework, in future release.
Comment 17 Marian Mirilovic 2005-10-05 16:45:05 UTC
Do you really want to leave it without mnemonic for NB 5.0 ? 

I can't believe it. Common, just think about it, change the name, find another
mnemonic.

Mnemonics in the main menu are the most important mnemonics in the IDE. How we
can ask another developers to fix mnemonics in any dialog, if we agree to leave
one of the main menu without it? 

And what about A11Y?

BTW: according to Bug priority guideline, this is P1:
http://qa.netbeans.org/processes/bug_priority_guidelines.html

If you really want to leave it without mnemonic for release, ask for waiver.
Comment 18 David Simonek 2005-10-05 17:00:34 UTC
Adding Honza to the loop.
Comment 19 Miloslav Metelka 2005-10-05 17:09:03 UTC
Mariane, which item of the Bug priority guidelines doc makes this to be
qualified as P1?

I guess there's too few non-conflicting shortcuts to satisfy all the requests so
the module developers should seriously start to think about using two-key
shortcuts for less commonly used actions (I know it's hard to say which one is
less used ;) )
The editor currently uses the following Alt-shortcuts:
Alt-G - goto declaration
Alt-J - select word
Alt-K - jump list back
Alt-L - jump list forward
Alt-O - open source
Alt-U - prefix key for several other actions
I'm prepared to make changes to these shortcuts if the UI team agrees on them.
Comment 20 Miloslav Metelka 2005-10-05 17:15:19 UTC
OK, I see what's wrong:

One of: accessible description, name, mnemonic is missing for a major component
such as a window, dialog box or main menu
Comment 21 Antonin Nebuzelsky 2005-10-05 20:55:12 UTC
Easy and quick solution - renaming the menu to "Navigate To" with ALT+N as the
mnemonic. How about that?
Comment 22 jrojcek 2005-10-06 12:04:12 UTC
Okay we're going to change the "Go To" menu to "Navigate" and use 'N' for mnemonic. This would mean 
adding "Go to" label into most of the items in Navigate menu. See the full spec in URL field.

Marian, please confirm that this solution will satisfy a11y.

Patrick or John, please approve or reject this late UI change.

Once we have the confirmation from Docs and QE, we should implement it for 5.0.
Comment 23 Marian Mirilovic 2005-10-06 12:44:48 UTC
It looks nice.

Probably we can group all Go To menu items under one submenu (see below).
But without deep and long discussion, I agreed with proposed solution.

================================
| Navigate |
------------
Go to  ->  Class...
           File...
           Test
           Recent Document
           ------------------
           Source
           Declaration
           Super Implementation
           Last Edit Location
           ------------------
           Line...
------------
Back
Forward
----------------------------
Toggle Bookmark
Next Bookmark
Previous Bookmark
----------------------------
*Next Method
*Previous Method
----------------------------
Next Error
Previous Error
----------------------------
Select in Projects 
Select in Files
Select in Favorites
=============================
Comment 24 John Jullion-ceccarelli 2005-10-07 01:49:20 UTC
I think it's OK. When would the final decision on this be? We need to update
several help pages and the keyboard shortcut guide. Please add it to
PromoFLateUIChanges and put me as the docs approver.
Comment 25 David Simonek 2005-10-10 09:43:15 UTC
I'm waiting for final decision on this as well: should I implement GoTo submenu
suggested by mmirilovic or not? jrojcek & mmirilovic please settle on final
solution and write final conclusion here, thanks.
My UI advice is to go without submenu, as it is one click/key press less for
frequently used features, which is IMHO more important then grouping/aesthetics
reasons that stands behind GoTo submenu.
Comment 26 David Simonek 2005-10-10 14:23:48 UTC
OK, after offline discussion FINAL solution is: redesign menu as UI spec in URL
field dictates, it means rename to Navigate with proper renaming of items in
menu. Submenus will *not* be introduced.

fixed in main trunk:
Checking in core/src/org/netbeans/core/Bundle.properties;
/cvs/core/src/org/netbeans/core/Bundle.properties,v  <--  Bundle.properties
new revision: 1.416; previous revision: 1.415
done
Checking in java/editor/src/org/netbeans/modules/editor/java/Bundle.properties;
/cvs/java/editor/src/org/netbeans/modules/editor/java/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.13; previous revision: 1.12
done
Checking in openide/actions/src/org/openide/actions/Bundle.properties;
/cvs/openide/actions/src/org/openide/actions/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.4; previous revision: 1.3
done
Checking in editor/src/org/netbeans/modules/editor/Bundle.properties;
/cvs/editor/src/org/netbeans/modules/editor/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.49; previous revision: 1.48
done
Checking in junit/src/org/netbeans/modules/junit/Bundle.properties;
/cvs/junit/src/org/netbeans/modules/junit/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.68; previous revision: 1.67
done
Checking in core/windows/src/org/netbeans/core/windows/actions/Bundle.properties;
/cvs/core/windows/src/org/netbeans/core/windows/actions/Bundle.properties,v  <--
 Bundle.properties
new revision: 1.19; previous revision: 1.18

HOWGH.

hopefully...
Comment 27 Marian Mirilovic 2005-10-26 10:36:40 UTC
verified in NB5.0(200510251800)