This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 72931 - Some queries/transformations cannot be opened in editor
Summary: Some queries/transformations cannot be opened in editor
Status: RESOLVED FIXED
Alias: None
Product: contrib
Classification: Unclassified
Component: Jackpot (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@contrib
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-22 13:39 UTC by Roman Strobl
Modified: 2006-03-22 04:49 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Strobl 2006-02-22 13:39:52 UTC
[NetBeans 5.0; Jackpot version 1.1.19]

In Command Manager there are some commands which cannot be opened in the editor.
I am not sure if this is a bug or if it's intentional. If it is intentional we
should explain the user why he can't open these commands.
Comment 1 _ tball 2006-02-22 18:37:12 UTC
This is because some queries and transformations are written using scripts,
while others are Java class files (like PMD).  The scripts are editable, while
the class files obviously are not.  I hope to convince marketing to distribute
the source to the query and transformer classes as part of the module's source,
but it's not practical for the Command Manager to try and find where the
engineer may have installed a copy of the module's source code.
Comment 2 Roman Strobl 2006-02-22 19:07:44 UTC
If you do not know the internals of Jackpot, you will not realize that some of
these commands are implemented as jars, not as rules. I accidentally read it a
while ago in the docs and understand it now. But a normal user may not
understand so explaining why the command cannot be opened in editor is useful. I
leave the judgement on you though.
Comment 3 _ tball 2006-02-22 19:17:20 UTC
What would you have as an alternative?  Would different icons help?  Would
mentioning in the help text that a command is a class be useful?  I am open to
different ways to fix this, but when the source is not available I don't know
what else to do besides disable the edit button.
Comment 4 Roman Strobl 2006-02-22 19:20:23 UTC
Explain that the rules file cannot be opened because this command is implemented
by a jar. I would write it on bottom of the form in small letter (similarly as a
message gets written to a status bar). I suggest to discuss this with NetBeans
UI engineers. It's not a big problem though.
Comment 5 _ tball 2006-02-22 19:34:23 UTC
I'll wait for any suggestions from the UI team -- thanks!
Comment 6 _ tball 2006-03-22 04:49:49 UTC
I added a label that shows the command file or class.  For rules files, it shows
the file path (such as Cleanup.rules), while transformers which are Java classes
show the classname (such as org.netbeans.modules.jackpot.cmds.SimplifyLoops). 
This should make it more obvious which commands are editable rules files, and
which are class files.