This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The default choice for the Type section is "No type", which is the least desirable choice. Either "Inline complex type" or "Use an existing type are much more prevalent in real-world use. The order of the radio button choices should possibly change to reflect user priority.
Let me add a couple of other comments to this dialog: * Titled borders should not be used. * It's not clear that the tree chooser below the radio buttons belongs to the "Use an existing type" radio button. Maybe this radio button should be the last one in the row. * There should be a validation message if Ok button is disabled. * Also when this dialog is in the editing mode, it's not clear what is the selected type (ok, it's in preview - but that's preview, which may be overlooked; the information should be in the Swing UI). At least, the visibility of the selected type should be ensured (suitable scrolling). Better, the radio button could be accompanied with a text field that would contain the qname of the selected type.
All customizers are modified. no titled borders. alignment is fixed. (Jirka, Todd) pl go through the customizers and let me know all the issues, if any. grouping of radio buttons and their corresponding type panels is rectified. below the type panel we will show current selection with its name, type and brief description (node description which is any annotation attached to that component) what do we want to show when * There should be a validation message if Ok button is disabled. where? at the bottom like import/include customizers?
I don't necessarily agree that there must be a validation message for disabled OK. It's a nice-to-have, but if it's there, it needs to be consistent with look and feel in the rest of the IDE (wizards are the only places with these), but there is no framework nor API for that. I'd rather just leave it out, frankly, since I don't think it's all that helpful in this case and just adds more opportunity for inconsistency and maintenance.
When a local element or global element is created, we will show customizer with inline complex type selected. It is most commonly used option.
Ajit, can you please attach a screenshot so we can more easily comment?
Created attachment 32664 [details] element customizer
This looks much better. However, it's not consistent with the NB layout guidelines: http://xdesign-tools.czech/internal/files/ui-training-presentation-May-Monrovia.odp
Todd, I have verified that the spacing between related components is 6. (exampl components use existing type and type panel) and spacing between unrelated components is 11 (name text field and type label for radio buttons). can you pl. verify? let me know any issues. (pl point them out)
There is also an issue in the customizer with the validation message. Space for validation message should be reserved and once it appears, the other components should stay in their original position and sizes - which is not the case now.
As prompted by tfast & jkopsa, marking this as VERIFIED.