This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 96348 - Partner view: Hiding partnerlinktypes when editor is active behaves unexpectedly
Summary: Partner view: Hiding partnerlinktypes when editor is active behaves unexpectedly
Status: VERIFIED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: WSDL Tools (show other bugs)
Version: 5.x
Hardware: All Windows XP
: P3 blocker (vote)
Assignee: Ritesh Adval
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-22 17:40 UTC by jlautz
Modified: 2007-03-08 03:07 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screen showing message name editor field (2.93 MB, application/octet-stream)
2007-02-22 17:42 UTC, jlautz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jlautz 2007-02-22 17:40:26 UTC
Seen on Windows XP with EP Gavotte 070220_4 and JDK 1.5.0_10:

1. Open a valid WSDL document.
2. Open or create a partnerlinktype, add an operation and double-click the
message name to activate editor for the operation name (or just double-click the
message name for an existing operation).
3. Click the WSDL editor toolbar button Show/Hide Partner Link Types.
==> The editor is still displayed.
See attached screenshot.

Also:

2. Double-click the Operation or Partner Link Type name to activate the renaming
editor field.
3. Click the WSDL editor toolbar button Show/Hide Partner Link Types.
=> The editor field closes/deactivates, but the PLT container is still displayed.
Comment 1 jlautz 2007-02-22 17:42:21 UTC
Created attachment 38819 [details]
Screen showing message name editor field
Comment 2 Ritesh Adval 2007-02-23 22:06:05 UTC
For first problem, This is a problem with inplace editor not getting closed. I
have a solution for this. Ideally this should be taken care by graph lib when a
widget is removed.

Something like if a widget has inplace editor action and when it is removed from
parent make sure to stop editing and remove the editor.

This will be fixed shortly. override notifyRemoved of a widget and close any in
place editor.

Second problem is not happening in debug, still investigating.
Comment 3 Ritesh Adval 2007-02-27 23:39:59 UTC
The first observation I added fixed the problem but may not be right solution.

The combobox in place editor for message was missing focus lost listener. After
adding that, first problem is fixed but it also now exhibits second problem.

The second problem is something which is probably needs to be fixed in graph lib.

The problems seems to be with parent widget of in place editor requesting focus:

From  InplaceEditorAction
public final void closeEditor (boolean commit) {

line 145

 parent.requestFocus ();

So when user starts editing and then click on the toolbar button, focus lost
event occurs on inplace editor, then above closeEditor calls parent.requestFocus
(), so the focus shifts to parent widget and the toolbar buttons action is not
getting invoked.

Other thing to note is that if I make the SceneComponent not focusable
scene.getView().setFocusable(false); then this problem does not occur.


Comment 4 David Kaspar 2007-02-28 13:31:16 UTC
The part #2 has been resolved by removing "parent.requestFocus ();" line from
the InplaceEditorAction.closeEditor method. The change is committed into the
"graph" module in the "release551" branch and the main trunk.
Comment 5 Ritesh Adval 2007-02-28 21:58:24 UTC
This is now fixed.
Comment 6 jlautz 2007-03-08 03:06:54 UTC
Verified on Windows XP with Gavotte 070306_14 and JDK 1.5.0_10.
Comment 7 jlautz 2007-03-08 03:07:57 UTC
Verified for original scenarios, but see also related issue 97439 and 97440.