Issue 108019 - Filename property in Base file connected to MS-Access database changed when file is closed
Summary: Filename property in Base file connected to MS-Access database changed when f...
Status: CLOSED FIXED
Alias: None
Product: Base
Classification: Application
Component: code (show other issues)
Version: OOO320m8
Hardware: PC Windows XP
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: marc.neumann
QA Contact: issues@dba
URL:
Keywords: regression
Depends on:
Blocks: 99999
  Show dependency tree
 
Reported: 2009-12-31 13:26 UTC by ud
Modified: 2010-01-13 23:10 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
attached screenshots (78.56 KB, application/pdf)
2009-12-31 13:28 UTC, ud
no flags Details
patch as committed (for the record, for review, for ...) (1.12 KB, patch)
2010-01-06 09:53 UTC, Frank Schönheit
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description ud 2009-12-31 13:26:21 UTC
I create a Base-file with an connection to an MS-Access97 database file.
Everything was OK, i get the tables and the queries as views and i could work
with the database.
But after close and reopen the file and went to the tables, the connection was
lost with the message: "wrong filename".
A simple
-> Edit/Database/Properties
-> pick up the same file by "Browse" dialog will solve the problem
-> save, close and reopen will open the same error-message

Please open the attached screenshots
Comment 1 ud 2009-12-31 13:28:07 UTC
Created attachment 66925 [details]
attached screenshots
Comment 2 drewjensen.inbox 2010-01-01 01:06:30 UTC
OOO320_m8 (RC1) Windows XP SP 3 and creating ODB files connected to MDB files,
also checked with ACCDB files - see note.

Confirmed

'\' is being added to the file name. So "C:\TestData\TireRating.mdb" becomes
"C:\TestData\TireRating.mdb\". (didn't check yet if it is on save or open..but
will).

Altered summary to match.

NOTE it is worse with ACCDB file connections, however this particular problem
also happens. Will open a separate issue for ACCDB because as opposed to here,
where you can fix the error per session, there is no way to fix the problem
there after the first time the file is closed (or opened again).
Comment 3 drewjensen.inbox 2010-01-01 01:59:02 UTC
The extraneous '\' is being added when the file is saved.
Comment 4 drewjensen.inbox 2010-01-03 03:49:39 UTC
The companion issue for accdb data type is 
http://www.openoffice.org/issues/show_bug.cgi?id=108040
Comment 5 Frank Schönheit 2010-01-04 12:10:00 UTC
Fixing this is not as easy as it might seem ...

In general, for file-based database types, OOo adds the / at the end of the
xlink:href value which points to the file or folder in question. The "file or
folder" is exactly the problem here: It would be easily possible to fix the
*import* code to strip this final slash. This would solve the problem here.

However, speaking strictly, it's already wrong to write the "....accdb/" part.
The URL here points to a file, so there must not be this final slash at all.

However, the slash was introduced for fixing issue 96134, where it indeed is
required, since the URL there denotes a folder.

So, for a proper fix, we would need to distinguish between a reference to a
folder and a reference to a file, which means extended the meta data for
database types, which perhaps isn't really trivial ... At least that's nothing I
would like to tamper with for 3.2 anymore, the more since even if this were
fixed, issue 108040 would still prevent us from using the MSA2007 databases
properly :-\
Comment 6 Frank Schönheit 2010-01-04 12:51:31 UTC
Okay, more investigations with Ocke's help showed that we can fix this properly,
and pretty risk-less, without tampering with the configuration data. Will carry
this to release@ooo.
Comment 7 mdxonefour 2010-01-04 13:43:56 UTC
Adjusting target as announced on releases mailing list.
Comment 8 Frank Schönheit 2010-01-04 14:04:38 UTC
fixed in CWS dba32k

find more information about this CWS, like when it is available in the master
builds, in EIS, the Environment Information System:
http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fdba32k
Comment 9 Frank Schönheit 2010-01-05 14:49:44 UTC
fs->msc: please verify in CWS dba32k
Comment 10 Frank Schönheit 2010-01-06 09:53:45 UTC
Created attachment 67021 [details]
patch as committed (for the record, for review, for ...)
Comment 11 marc.neumann 2010-01-06 11:39:22 UTC
verified in CWS dba32k

find more information about this CWS, like when it is available in the master
builds, in EIS, the Environment Information System:
http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fdba32k
Comment 12 ocke.janssen 2010-01-06 11:48:18 UTC
Patch verified.
Comment 13 drewjensen.inbox 2010-01-13 23:10:07 UTC
checked w/ xp, ooo320_R2

closing