Issue 113047 - The grayed-out text "Find" in the new findbar is unlocalizable
Summary: The grayed-out text "Find" in the new findbar is unlocalizable
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@sw
URL:
Keywords:
: 113252 (view as issue list)
Depends on:
Blocks:
 
Reported: 2010-07-09 10:17 UTC by miles
Modified: 2017-05-20 11:42 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description miles 2010-07-09 10:17:44 UTC 
Using Pavel's OOO330m0 Slovenian build for OS X with current Slovenian SDF file
- 100% localized - and an English word (Find) appears grayed-out in the new Find
bar in Writer.

I checked the po files and all appearances of "Find" are translated as "Najdi",
so this should mean it is not localizable, which would be a showstopper for 3.3.

Since OOO330m0 is not on the list of versions I set it to "current".

Thanks, m.
Comment 1 eric.savary 2010-07-12 01:27:18 UTC 
@SBA: please have a look.
For sure it's not translated yet.
Comment 2 stefan.baltzer 2010-07-12 13:09:16 UTC 
SBA->CD: Please proceed.
Comment 3 carsten.driesner 2010-07-12 13:24:01 UTC 
cd->wuy: Please take over. Did you forget to use a resource entry for the text?
Hard-coded strings are clearly forbidden as they cannot be localized.
Comment 4 carsten.driesner 2010-07-12 13:35:47 UTC 
cd->wuy: Please fix the following code in
svx/tbxctrls/tbunosearchcontrollers.cxx which violates the coding standards of
OOo. Text must be translatable and therefore placed in resource files!

void FindTextFieldControl::InitControls_Impl()
{
    SetText( String( ::rtl::OUString::createFromAscii("Find") ) );
    ...
Comment 5 stefan.baltzer 2010-07-12 14:07:29 UTC 
Set target OOo 3.3.
Comment 6 wuyan.ooorg 2010-07-13 10:53:01 UTC 
Started.
Comment 7 carsten.driesner 2010-07-20 12:42:17 UTC 
*** Issue 113252 has been marked as a duplicate of this issue. ***
Comment 8 carsten.driesner 2010-07-20 13:14:27 UTC 
cd: Fixed.
Comment 9 carsten.driesner 2010-07-21 13:26:41 UTC 
cd->sba: Please verify.
Comment 10 stefan.baltzer 2010-07-22 12:13:42 UTC 
Verified in CWS fwk150.
Comment 11 grakic 2010-07-26 18:04:45 UTC 
What about "Find & Replace" button name visible when one try to add this button 
to new Find toolbar? What is the ID of this message or this also left out as hard 
coded string?
Comment 12 odahlum 2010-07-26 18:34:02 UTC 
Anyone with File > Properties? Both the "find" issue and others are quite
noticeable, so I want to prevent any bad publicity...
Comment 13 miles 2010-07-26 18:54:35 UTC 
olavd, I can also see it in the ooo330l10n Slovenian build: File - Properties,
then Security tab.
The funny thing is that the first line of that non-localizable text even exists
in the sdf (cui\source\dialogs.po) as "Note: After a password has been set, the
document will only open with ", without the rest of the text. It was localized
in the Slovenian sdf but in the build it is in English, and much longer, of course.

However, this should be filed as another issue.
Comment 14 andreschnabel 2010-07-26 19:00:19 UTC 
note: just filed issue 113440 for the file - properties - security problem.

Please remember the rule: one problem per issue
Comment 15 odahlum 2010-07-27 01:42:35 UTC 
Thanks for the reminder, but the frustration kicks in when deadlines are getting
closer and things still fail. ;-)
Comment 16 odahlum 2010-07-27 01:48:03 UTC 
Will the templates be updated?