Issue 119554 - [From Symphony]3D extrusion direction gets lost in MS powerpoint after AOO save as .ppt file
Summary: [From Symphony]3D extrusion direction gets lost in MS powerpoint after AOO sa...
Status: REOPENED
Alias: None
Product: Impress
Classification: Application
Component: save-export (show other issues)
Version: 3.4.0
Hardware: PC All
: P2 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 05:46 UTC by Li Feng Wang
Modified: 2017-05-20 11:27 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
sample file (12.50 KB, application/vnd.ms-powerpoint)
2012-05-30 05:46 UTC, Li Feng Wang 		no flags Details
screenshot of before save (57.73 KB, image/png)
2012-05-30 05:48 UTC, Li Feng Wang 		no flags Details
screenshot of after save (26.14 KB, image/png)
2012-05-30 05:48 UTC, Li Feng Wang 		no flags Details
patch for the issue (1.10 KB, patch)
2012-06-12 03:25 UTC, Lei Debin 		debin.lei: review?
Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Li Feng Wang 2012-05-30 05:46:56 UTC 
Created attachment 77766 [details]
sample file

build:
AOO3.4 r1327774

steps:
1. Launch AOO3.4 
2. Open the attached .ppt file    
3. Save it to another .ppt file
4. Reopen it with ms powerpoint
5. Check the 3D effect in the slide 1.

Defect:See the attached snapshots, the 3D shape doesn't have 3D extrusion direction any more after saved by AOO3.4.
Comment 1 Li Feng Wang 2012-05-30 05:48:07 UTC 
Created attachment 77768 [details]
screenshot of before save
Comment 2 Li Feng Wang 2012-05-30 05:48:44 UTC 
Created attachment 77769 [details]
screenshot of after save
Comment 3 Lei Debin 2012-06-12 02:54:56 UTC 
I am looking at the issue
Comment 4 Lei Debin 2012-06-12 02:59:46 UTC 
The direct properties of the 3D object in sample file are 
DFF_Prop_c3DXViewpoint, DFF_Prop_c3DYViewpoint,,DFF_Prop_c3DZViewpoint.
the values are 1250000, 1250000, 9000,
while AOO saved as 1249920, 1249920, 9000.

So the root cause is using one wrong default value.
Need correct it.
Comment 5 Lei Debin 2012-06-12 03:25:17 UTC 
Created attachment 78241 [details]
patch for the issue
Comment 6 Andre 2012-06-12 11:14:16 UTC 
Reviewing.
Comment 7 Andre 2012-06-12 11:47:35 UTC 
I have no Powerpoint to verify the fix, but the patch looks good.

Commited. SVN revision is 1349274.

@Lei Debin: Can you comment on the magic numbers that are used here (besides the fact that one works and the other don't)?
Comment 8 liuping 2012-06-21 06:59:21 UTC 
I found bug still exist in AOO version 1351249
Comment 9 Andre 2012-06-21 07:12:58 UTC 
@Lei Debin: Can you take care of this?
Comment 10 Lei Debin 2012-06-21 09:39:49 UTC 
@Andre: yes, I will. Sorry for the partial fix :-(
In fact, I found the fix not completed, when I did some code review for 119537.
And I have tested the patch from 119537, the issue will be resolved.
As I do not get the commit right until now, can you help to review and check in for 119537?
Comment 11 Andre 2012-06-21 11:40:37 UTC 
@Lei Debin: I have checked in the fix for bug 119537.
Comment 12 Li Feng Wang 2012-08-20 06:12:51 UTC 
Verified Pass on Windows XP and Mac with AOo trunk r1374181.
But Fail on Redhat 32bit.
In step4, the 3D shape doesn't have 3D extrusion direction any more after saved on Redhat 32bit.
Comment 13 Li Feng Wang 2012-08-20 06:17:42 UTC 
fail on Redhat
Comment 14 Marcus 2017-05-20 11:27:44 UTC 
Reset assigne to the default "issues@openoffice.apache.org".