Issue 121643 - Change All in spell check deletes trailing period
Summary: Change All in spell check deletes trailing period
Status: CONFIRMED
Alias: None
Product: Writer
Classification: Application
Component: editing (show other issues)
Version: 3.4.1
Hardware: All All
: P3 Normal with 2 votes (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact: Suchithra
URL:
Keywords:
: 121646 (view as issue list)
Depends on:
Blocks:
 
Reported: 2013-01-18 17:11 UTC by Steve Culver
Modified: 2015-01-15 09:00 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 3.4.1
Developer Difficulty: Simple

Attachments
Bug 121643] Change All in spell check deletes trailing period (21.82 KB, image/png)
2013-01-20 16:51 UTC, Suchithra 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Steve Culver 2013-01-18 17:11:19 UTC 
If a misspelled word is also the last word in a sentence, the final period will be deleted after you select "Change All". Interestingly, it does NOT happen when you choose "Change".
Comment 1 Suchithra 2013-01-20 16:51:36 UTC 
Created attachment 80152 [details]
Bug 121643] Change All in spell check deletes trailing period
Comment 2 Suchithra 2013-01-20 16:52:55 UTC 
This issue is  reproducible in build:9593, details attached. 
Steps to reproduce:
1) Created a new file  open office word processor.
2) Entered data like "I have a class tommorrow".
3) Clicked on spell check and selected "Change All".
4) It did deleted the trailing period.
5) Created another  file  open office word processor.
6) Entered data like "I have a class tommorrow".
7) Clicked on spell check and selected "Change".
8) It did not delete the trailing period.
Comment 3 Ariel Constenla-Haile 2013-01-24 03:58:05 UTC 
Changing a single spelling error takes care of trailling spaces (it tracks them, stores the state and restores them if the replacement has no trailing space)

IMPL_LINK( SpellDialog, ChangeHdl, Button *, EMPTYARG )

http://svn.apache.org/viewvc/openoffice/trunk/main/cui/source/dialogs/SpellDialog.cxx?revision=1413471&view=markup#l621

when changing all, this is not taken into account:

IMPL_LINK( SpellDialog, ChangeAllHdl, Button *, EMPTYARG )

http://svn.apache.org/viewvc/openoffice/trunk/main/cui/source/dialogs/SpellDialog.cxx?revision=1413471&view=markup#l643
Comment 4 hanya 2015-01-15 09:00:46 UTC 
*** Issue 121646 has been marked as a duplicate of this issue. ***