Issue 124877 - reset formatting behind special formattings hangs AOO
Summary: reset formatting behind special formattings hangs AOO
Alias: None
Product: Writer
Classification: Application
Component: formatting (show other issues)
Version: 4.1.0
Hardware: All All
: P3 Normal with 2 votes (vote)
Target Milestone: 4.1.1
Assignee: Oliver-Rainer Wittmann
QA Contact:
Keywords: regression
: 124938 125178 125184 125276 125407 (view as issue list)
Depends on:
Blocks: 124985
  Show dependency tree
Reported: 2014-05-12 18:53 UTC by TAB
Modified: 2017-05-20 10:35 UTC (History)
11 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.1.1_release_blocker+

file with style to reset (11.96 KB, application/vnd.oasis.opendocument.text)
2014-05-12 18:53 UTC, TAB
no flags Details
another document that demonstrates the crash (24.05 KB, application/vnd.oasis.opendocument.text)
2014-05-14 12:58 UTC, mroe
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description TAB 2014-05-12 18:53:41 UTC
Created attachment 83377 [details]
file with style to reset

Open freezeD.odt, put the cursor before 'AAA', hit ^m for DefaultFormatting. OO becomes 'Not responding'.
Double-clicking Numbering 3 in the Styles&Formatting window does restore the formatting as expected.
^m also does it if the cursor is after 'AAA'. AFTER that, putting the cursor before 'AAA' and hitting ^m does nothing --does not hang OO.
	Thinking it might be due to user-profile corruption, I reset it according to 
Resetting the user profile

Same result.
Comment 1 mroe 2014-05-12 19:23:43 UTC
Can confirm for 4.1 Linux but not for earlier versions so set the keyword REGRESSION. The issue occurs also by sing the (context) menu entry.
Comment 2 Oliver Brinzing 2014-05-14 05:20:19 UTC
can confirm on w7 64bit with aoo410
Comment 3 mroe 2014-05-14 12:58:45 UTC
Created attachment 83384 [details]
another document that demonstrates the crash

Attached is another document that demonstrates the crash at another position.

Description to reproduce is inside the document.
Comment 4 David Paenson 2014-05-14 13:34:03 UTC
Reproducible on Windows XP and under Ubuntu 14.04 using AOO 4.1.

No problem under AOO 4.0.1.
Comment 5 mroe 2014-05-20 10:42:56 UTC
*** Issue 124938 has been marked as a duplicate of this issue. ***
Comment 6 Ariel Constenla-Haile 2014-05-20 10:49:37 UTC
Attaching the debugger shows a recurrent place in sw/source/core/txtnode/txtedt.cxx

(gdb) bt
#0  SfxItemSet::GetItemState (this=0x2e4f138, nWhich=118, bSrchInParent=0 '\000', ppItem=0x0) at /build/aoo/src/playground/trunk/main/svl/source/items/itemset.cxx:511
#1  0x00007f40d1a1d850 in lcl_HaveCommonAttributes(IStyleAccess&, SfxItemSet const*, unsigned short, SfxItemSet const&, boost::shared_ptr<SfxItemSet>&) ()
   from /home/ariel/aoo/installation/openoffice4/program/../program/
#2  0x00007f40d1a1e88d in SwTxtNode::RstTxtAttr(SwIndex const&, unsigned short, unsigned short, SfxItemSet const*, unsigned char) ()
   from /home/ariel/aoo/installation/openoffice4/program/../program/
#3  0x00007f40d1833c6b in lcl_RstTxtAttr(SwNode* const&, void*) () from /home/ariel/aoo/installation/openoffice4/program/../program/
#4  0x00007f40d17d4b4c in BigPtrArray::ForEach(unsigned long, unsigned long, unsigned char (*)(BigPtrEntry* const&, void*), void*) ()
   from /home/ariel/aoo/installation/openoffice4/program/../program/
#5  0x00007f40d18369ea in SwDoc::ResetAttrs(SwPaM const&, unsigned char, SvUShortsSort const*, bool) () from /home/ariel/aoo/installation/openoffice4/program/../program/
#6  0x00007f40d18c891e in SwEditShell::ResetAttr(SvUShortsSort const*) () from /home/ariel/aoo/installation/openoffice4/program/../program/
#7  0x00007f40d1c7cadd in SwTextShell::Execute(SfxRequest&) () from /home/ariel/aoo/installation/openoffice4/program/../program/

may be introduced in one of this revisions
Revision 1458875 
Revision 1527563 
Revision 1542986

Setting Olivier on CC.
Comment 7 Oliver-Rainer Wittmann 2014-05-23 10:18:15 UTC
taking over to have a closer look.
Comment 8 Oliver-Rainer Wittmann 2014-05-23 10:33:40 UTC
Very serious defect introduced by changes made for issue 123389 - revision 1527563 as Ariel already had noticed.

My refactoring to method <SwTxtNode::RstTxtAttr(..)> caused this defect.

Fix is in progress.
Comment 9 SVN Robot 2014-05-23 12:23:41 UTC
"orw" committed SVN revision 1597076 into trunk:
124877: method <SwTxtNode::RstTxtAttr(..)> - correct refactoring (made for is...
Comment 10 Oliver-Rainer Wittmann 2014-05-23 12:31:21 UTC
fixed on trunk
Comment 11 jsc 2014-06-16 09:11:59 UTC
grant showstopper flag, regression and already fixed
Comment 12 SVN Robot 2014-06-19 09:36:10 UTC
"orw" committed SVN revision 1603785 into branches/AOO410:
124877: method <SwTxtNode::RstTxtAttr(..)> - correct refactoring (made for is...
Comment 13 Oliver-Rainer Wittmann 2014-06-19 09:39:33 UTC
fixed on branch AOO410 for planned 4.1.1 release
Comment 14 jolatt 2014-06-25 13:17:14 UTC
Verified with AOO411m1(Build:9770)  -  Rev. 1603804 on Ubuntu 14.03
Comment 15 David Paenson 2014-06-30 11:38:43 UTC
OK. Resolved. No crash observed unter AOO 4.1.1 Build 9770 Ubuntu 14.04.
Comment 16 Oliver-Rainer Wittmann 2014-07-02 08:14:04 UTC
*** Issue 125184 has been marked as a duplicate of this issue. ***
Comment 17 Oliver-Rainer Wittmann 2014-07-02 08:20:50 UTC
*** Issue 125178 has been marked as a duplicate of this issue. ***
Comment 18 fanyuzhen 2014-07-16 13:02:30 UTC
It's verified fixed in build AOO411m1(Build:9770)  -  Rev. 1603804 on Win 7
Comment 19 rgb 2014-07-18 20:43:25 UTC
*** Issue 125276 has been marked as a duplicate of this issue. ***
Comment 20 Ariel Constenla-Haile 2014-08-11 21:29:28 UTC
*** Issue 125407 has been marked as a duplicate of this issue. ***