Issue 36052 - configure needs to test for visibility
Summary: configure needs to test for visibility
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: rene
QA Contact: issues@tools
URL:
Keywords:
Depends on: 36160
Blocks:
  Show dependency tree
 
Reported: 2004-10-24 12:53 UTC by foskey
Modified: 2005-03-31 15:40 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2004-10-24 12:53:31 UTC 
The current tests in sw/inc/ check for the version of gcc before adding
visibility options.  This needs to be optioned based on compiler capabilities
not version numbers (eg debian gcc 3.4 does not have patches).

# set default symbol visibility / scope to hidden
.IF "$(COMNAME)" == "gcc3"
.IF "$(CCNUMVER)" >= "000300040000"
CFLAGS += -fvisibility=hidden
.ENDIF # 3.4.0
.ENDIF # gcc3

First part is to make configure detect visibility (perhaps by that option) and
then create a working varaible so that we can test for it.
Comment 1 matthias.huetsch 2004-10-26 18:28:32 UTC 
Adding dependency to issue 36160, and adding myself to CC...
Comment 2 rene 2005-01-13 23:03:58 UTC 
Reassign to me
Comment 3 rene 2005-01-13 23:14:06 UTC 
committed to cws_src680_configure4
Comment 4 rene 2005-01-14 02:17:01 UTC 
set to FIXED
Comment 5 quetschke 2005-01-24 00:05:38 UTC 
*env.set sets $HAVE_GCC_VISIBILITY_FEATURE in configure4
Comment 6 rene 2005-03-31 15:40:44 UTC 
close