Apache OpenOffice (AOO) Bugzilla – Issue 36160
GCC "visibility" feature: need feature test instead of version test
Last modified: 2013-08-07 15:35:05 UTC
Summary says it all: don't test for GCC version, but for feature availability. i.e. #if (_GCC_MAJOR >= 3) && (_GCC_MINOR >= 4) ... #endif needs to be changed into something like #if defined(HAVE_GCC_VISIBILITY_FEATURE) ... #endif This applies to 'sal/inc/sal/types.h' as well as the makefiles where this is (to be) used (currently: 'sw/inc/sw.mk', 'sc/util/makefile.pmk', 'sd/util/makefile.mk'). The 'HAVE_GCC_VISIBILITY_FEATURE' needs then be 'configure'd (see issue 36052, which depends on this one).
Accepting...
Adding Ken and Ause to CC...
Fixed in 'solenv/inc/unxlngi{4,5,6}.mk', 'sal/inc/sal/types.h', 'sc/util/makefile.pmk', 'sd/util/makefile.pmk', and 'sw/inc/sw.mk' on cws_src680_gccvisibilityfix.
Environment variable 'HAVE_GCC_VISIBILITY_FEATURE' set by (Hamburg internal) 'setsolar.pl'. 'configure' will be adapted via issue 36052. Code reviewed (developer / tools task) => verified.
Fix integrated into milestone 680m60 (alias 1.9.m60) => closing.