Issue 66032 - Mailing lists: descriptions do not respect HTML formatting
Summary: Mailing lists: descriptions do not respect HTML formatting
Status: CLOSED FIXED
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: Upgrade (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Unknown
QA Contact: issues@www
URL:
Keywords:
: 66782 67288 (view as issue list)
Depends on:
Blocks: 64392
  Show dependency tree
 
Reported: 2006-06-02 09:36 UTC by Frank Schönheit
Modified: 2012-03-01 21:59 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Frank Schönheit 2006-06-02 09:36:18 UTC
In the current SourceCast installation (2.6), when you enter HTML markup in the
description of a document/file, this markup is respected when displaying the
document list.

In the new SourceCast installation (3.5.1), it isn't anymore.

Cp.
http://dba.stage.openoffice.org/servlets/ProjectMailingListList
with
http://dba.openoffice.org/servlets/ProjectMailingListList
Comment 1 stx123 2006-06-04 19:50:46 UTC
reassign to support
Comment 2 Unknown 2006-06-05 17:19:22 UTC
Hi St
          I am checking this.

Regards
Karthik
Support Operations
Comment 3 Unknown 2006-06-05 17:23:37 UTC
updating status whiteboard.

Regards,
Karthik
Support Operations
Comment 4 Unknown 2006-06-06 00:42:41 UTC
I have asked my engineers to have a look at the issue,will get back to you at
the earliest.

Regards,
Karthik
Support Operations
Comment 5 Unknown 2006-06-06 01:16:09 UTC
Hello Frank,

The problem that you reported is due to changes made in release 3.x. Please 
refer to: http://www.collab.net/rn/3_0_0.html: Issue 25737

"To prevent cross-site scripting security issues HTML, without XSS scripting 
tags, can be passed to the browser from specific areas of the application. 
Each HTML submission will be passed through a "scripting safe" filter 
responsible for detecting scripting tags and applying a full filter if they 
are encountered."

Project mailing list descriptions were changed to not allow HTML markup.

Thanks
Comment 6 Unknown 2006-06-06 01:17:13 UTC
In the previous post, the URL is :http://www.collab.net/rn/3_0_0.html
Search for 25737.
Comment 7 stx123 2006-06-07 20:20:28 UTC
*** Issue 66031 has been marked as a duplicate of this issue. ***
Comment 8 Frank Schönheit 2006-06-09 09:36:54 UTC
Thanks for the explanations.

> Project mailing list descriptions were changed to not allow HTML markup.

Is there a reason for this? I understand the security concerns if we would allow
arbitrary HTML, since the HTML is filtered, anyway, why not adding project list
descriptions to HTML-allowed list? Please consider this (also for document
descriptions, see issue 66031), or explain why it is not an option. Thanks.
Comment 9 Unknown 2006-06-26 20:12:54 UTC
Hi Fs
             I will check this with my engineer and get back to you asap.

Regards,
Karthik
Support Operations
Comment 10 stx123 2006-06-28 11:37:36 UTC
*** Issue 66782 has been marked as a duplicate of this issue. ***
Comment 11 Unknown 2006-07-05 19:50:33 UTC
Hi Fs
           Upon further investigation, this was fixed in release 4.0:
 In earlier releases, CollabNet guarded Mailing List descriptions from
cross-site scripting vulnerabilities and so did not allow allow HTML script.
This did not allow the end-user to include scripts in their snippets. For
example, if you were to do the following:
Create a project (standard).
Add a HTML script tag to the description field in a mailing list.
On the UI, go to the new project's mailing list screen.
You will notice that the script that you added is rendered.

Solution: This has been fixed in the current release. A simple subset of HTML
will be rendered now, and potentially malicious HTML will cause all HTML to be
escaped.

----------------------------------

We can override the template until your site is upgraded to 4.x 

The same fix doesn't apply to Documents and files descriptions since they appear
in a very limited location, HTML markup may be more risky.


Thanks,
Karthik
Support Operations
Comment 12 Frank Schönheit 2006-07-06 07:51:13 UTC
Thanks, but this does mean /what/, please? I see an explanation why it is as it
is, but will we be able to use HTML in the descriptions, again? If "override the
template" means that HTML will be allowed then, does it also mean that we're
prone to cross-site scripting, again?

If so, please instead consider my suggestion: According to
http://www.collab.net/rn/3_0_0.html, there's a number of places which do allow
restricted HTML - is it possible to add "mailing list descriptions" to this list?
Comment 13 Frank Schönheit 2006-07-13 06:47:00 UTC
removing "stage" from the summary, as now this is a problem of the alive site.
Comment 14 stx123 2006-07-13 09:22:18 UTC
*** Issue 67288 has been marked as a duplicate of this issue. ***
Comment 15 Unknown 2006-07-14 21:59:33 UTC
Hi Frank
         I shall check this with my engineers and get back to you.

Thanks,
Karthik
Support Operations
Comment 16 Unknown 2006-08-04 06:33:03 UTC
We would be trying out the solution mentioned in des 12 in the stage box.
Essentially what we would be doing is allow restricted HTML to be rendered in
"mailing list descriptions" and escaped anything which seems to contain
malicious HTML tags.
Comment 17 Unknown 2006-08-07 10:49:54 UTC
The changes has been applied on the production box whereby restricted HTML would
be rendered in description field .Make sure that the break tags are in the
format given below to correctly render .

e.g issues@dba.openoffice.org mailing list needs a edit. The break tag
should be <br /> and not <br/> there should be a space in-between br and /,
which is missing in the issues mailing list description.

Please correct the same and also confirm if the issue has been fixed.

Comment 18 Frank Schönheit 2006-08-07 11:11:28 UTC
works like a charm, thanks a lot!
Comment 19 stx123 2006-08-08 20:08:57 UTC
verified and closing...
Comment 20 lohmaier 2006-08-22 11:27:04 UTC
reopen.
Only fixed in the mailing-list overview, but not in the description when viewing
the archive.
e.g. fixed for
http://de.openoffice.org/servlets/ProjectMailingListList but not for
http://de.openoffice.org/servlets/SummarizeList?listName=announce
Comment 21 Unknown 2006-08-22 13:46:33 UTC
We need to check which the engineer if the same kind of workaround we perform
for the ProjectMailingListList can be perform on the link mentioned above . For
now i am reopening the internal issue for their feedback on this issue .
Comment 22 Unknown 2006-08-23 08:09:28 UTC
Cloph , 

   The workaround/changes were performed in the stage box .Verified that html
are getting rendered properly . Requested the engineer to perform the same
change in the production box .

Also verified in the production box that the HTML the tags are not shown in the
List Description field present in the archive.

Closing this issue .
Comment 23 stx123 2006-08-24 13:59:03 UTC
verified and closing...