Issue 79666 - Please add support for language variants to i18npool
Summary: Please add support for language variants to i18npool
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: i18npool (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: ooo
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks: 56622 79665
  Show dependency tree
 
Reported: 2007-07-16 15:05 UTC by ivo.hinkelmann
Modified: 2013-08-07 15:01 UTC (History)
1 user (show)

See Also:
Issue Type: FEATURE
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ivo.hinkelmann 2007-07-16 15:05:17 UTC 
Please add support for language variants to i18npool. Language variants are for
example like "en-US-ooo" or "pt-BR-so" . Please provide a fallback routine thus
pt-BR-so fallsback to pt-BR and not en-US. Language variants are needed for
issue 56622
Comment 1 ivo.hinkelmann 2007-07-16 15:41:35 UTC 
set target to OOo 2.4
Comment 2 ooo 2007-07-17 11:36:42 UTC 
Accepted.
Comment 3 ooo 2007-10-26 11:21:58 UTC 
Actually this was already implemented with issue 73506 in cws 'localefallback'
integrated to SRC680m222. See interface announcement
http://www.openoffice.org/servlets/ReadMsg?list=interface-announce&msgNo=1076
Note that only a fall-back is implemented as variants aren't supported yet
throughout the entire code base.
Comment 4 ooo 2007-10-26 11:23:16 UTC 
Closing.
Comment 5 ivo.hinkelmann 2007-11-01 18:41:36 UTC 
I am testing your fallback method .... could it be that "pt-BR-so" fallsback to
"pt" instead of "pt-BR" ?
Comment 6 ooo 2007-11-01 21:15:57 UTC 
No, can't be ;-)  At least it shouldn't ... how do you call it? Use
::com::sun::star::lang::Locale MsLangId::getFallbackLocale( const
::com::sun::star::lang::Locale & rLocale )

with
rLocale.Language == "pt"
rLocale.Country == "BR"
rLocale.Variant == "so"

There isn't even a "pt" only entry in the table used, so if I didn't do a nasty
typo resulting in an assignment of an empty string as country somewhere it
should work. If not, please prepare a debug version of your code and i18npool's
libisolang so we can step through.