Issue 82608 - vcl: gtk themes like ThinIce reveals we're using incorrect frees on theme resources
Summary: vcl: gtk themes like ThinIce reveals we're using incorrect frees on theme res...
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 2.3.0 RC1
Hardware: All Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 2.3.1
Assignee: stefan.baltzer
QA Contact: issues@gsl
URL:
Keywords:
: 79711 82078 83579 83682 83737 83745 (view as issue list)
Depends on:
Blocks:
 
Reported: 2007-10-15 02:20 UTC by drmarcelorosa73
Modified: 2008-03-13 17:18 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch to fix (1006 bytes, patch)
2007-10-19 09:50 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description drmarcelorosa73 2007-10-15 02:20:55 UTC
When I tried to alter the character in a doc (FORMAT -> CHARACTER...), Writer
crashes. It also happened when I use several commands that results in an attempt
of WRITE to open a dialog box.

Marcelo.


(I)    x.org loaded video driver of...
(II) Loading /usr/lib64/xorg/modules/drivers//nvidia_drv.so
(--) Depth 24 pixmap format is 32 bpp
(III)  Desktop is: GNOME
(IV)   libgcj version is: libgcj-4.1.2-31-x86_64 libgcj-4.1.2-31-i386
(V)    kernel is: Linux 2.6.23-6.fc8 #1 SMP Thu Oct 11 13:36:39 EDT 2007 x86_64
x86_64 x86_64
(VI)   OpenOffice.org core rpm version is: openoffice.org-core-2.3.0-6.1.fc8-x86_64
(VII)  accessibility is: false
(VIII) fedora release is: Fedora release 7.92 (Rawhide)
...start free space details ...
Filesystem           1K-blocks      Used Available Use% Mounted on
/dev/mapper/VolGroup00-LogVol00
                      46913896   5850948  38641396  14% /
/dev/mapper/VolGroup00-LogVol00
                      46913896   5850948  38641396  14% /
...end free space details ...
...start sestatus details ...
SELinux status:                 enabled
SELinuxfs mount:                /selinux
Current mode:                   permissive
Mode from config file:          permissive
Policy version:                 21
Policy from config file:        targeted
...end sestatus details ...
...start stackreport details ...
0x00000032f8636a74: 0x00000000001ebc08:
/usr/lib64/openoffice.org/program/libuno_sal.so.3 + 0x36a74
0x00000032f863786a: 0x00000000001ebc08:
/usr/lib64/openoffice.org/program/libuno_sal.so.3 + 0x3786a
0x00000032f9c0e530: 0x0000000000015da8: /lib64/libpthread.so.0 + 0xe530
0x00000032f9030e65: 0x000000000014fb60: /lib64/libc.so.6 + 0x30e65 (gsignal + 0x35)
0x00000032f9032910: 0x000000000014fb60: /lib64/libc.so.6 + 0x32910 (abort + 0x110)
0x00000032f906b06b: 0x000000000014fb60: /lib64/libc.so.6 + 0x6b06b
0x00000032f90727c2: 0x000000000014fb60: /lib64/libc.so.6 + 0x727c2
0x00000032f9075ebc: 0x000000000014fb60: /lib64/libc.so.6 + 0x75ebc (cfree + 0x8c)
0x00002aaaaf5bdbb8: 0x0000000000058608:
/usr/lib64/openoffice.org/program/libvclplug_gtk680lx.so + 0x3dbb8
(GtkSalGraphics::getNativeControlRegion(unsigned int, unsigned int, Region
const&, unsigned int, ImplControlValue const&, SalControlHandle&, rtl::OUString
const&, Region&, Region&) + 0x988)
0x000000330387cb78: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x27cb78
(SalGraphics::GetNativeControlRegion(unsigned int, unsigned int, Region const&,
unsigned int, ImplControlValue const&, SalControlHandle&, rtl::OUString const&,
Region&, Region&, OutputDevice const*) + 0x168)
0x000000330393032a: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x33032a
(Window::GetNativeControlRegion(unsigned int, unsigned int, Region const&,
unsigned int, ImplControlValue const&, rtl::OUString, Region&, Region&) + 0x11a)
0x000000330397123f: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x37123f (ListBox::Resize() +
0x19f)
0x000000330391a3d9: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x31a3d9
(Window::ImplCallResize() + 0x39)
0x000000330391c616: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x31c616
(Window::Show(unsigned char, unsigned short) + 0xd6)
0x0000003306c89f69: 0x00000000004f9730:
/usr/lib64/openoffice.org/program/libsvt680lx.so + 0x289f69
(ColorListBox::ColorListBox(Window*, ResId const&) + 0x9)
0x00002aaabf607aac: 0x000000000031eb88:
/usr/lib64/openoffice.org/program/libcui680lx.so + 0x27faac
0x00002aaabf608b34: 0x000000000031eb88:
/usr/lib64/openoffice.org/program/libcui680lx.so + 0x280b34
0x00000033089ec171: 0x00000000004a9e48:
/usr/lib64/openoffice.org/program/libsfx680lx.so + 0x3ec171
(SfxTabDialog::ActivatePageHdl(TabControl*) + 0x3a1)
0x00000033089ec2d8: 0x00000000004a9e48:
/usr/lib64/openoffice.org/program/libsfx680lx.so + 0x3ec2d8
(SfxTabDialog::Start_Impl() + 0xc8)
0x00000033089ec4af: 0x00000000004a9e48:
/usr/lib64/openoffice.org/program/libsfx680lx.so + 0x3ec4af
(SfxTabDialog::Execute() + 0x1f)
0x00002aaabefc2241: 0x0000000000262438:
/usr/lib64/openoffice.org/program/libswui680lx.so + 0xa3241
0x00002aaabb117228: 0x0000000000e76a28:
/usr/lib64/openoffice.org/program/libsw680lx.so + 0xbfe228
(SwTextShell::Execute(SfxRequest&) + 0x1ad8)
0x0000003308940a97: 0x00000000004a9e48:
/usr/lib64/openoffice.org/program/libsfx680lx.so + 0x340a97
(SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, unsigned char)
+ 0x237)
0x00000033089411c1: 0x00000000004a9e48:
/usr/lib64/openoffice.org/program/libsfx680lx.so + 0x3411c1
(SfxDispatcher::PostMsgHandler(SfxRequest*) + 0x121)
0x000000330896aeda: 0x00000000004a9e48:
/usr/lib64/openoffice.org/program/libsfx680lx.so + 0x36aeda
(SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) + 0xa)
0x000000330392b351: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x32b351
(ImplWindowFrameProc(void*, SalFrame*, unsigned short, void const*) + 0x611)
0x00002aaab00d04df: 0x00000000000948b0:
/usr/lib64/openoffice.org/program/libvclplug_gen680lx.so + 0x6a4df
(SalDisplay::DispatchInternalEvent() + 0xbf)
0x00002aaaaf5a1bd9: 0x0000000000058608:
/usr/lib64/openoffice.org/program/libvclplug_gtk680lx.so + 0x21bd9
(GtkXLib::userEventFn(void*) + 0xa9)
0x00000032fa42eee3: 0x00000000000c5db8: /lib64/libglib-2.0.so.0 + 0x2eee3
(g_main_context_dispatch + 0x1c3)
0x00000032fa4321dd: 0x00000000000c5db8: /lib64/libglib-2.0.so.0 + 0x321dd
0x00000032fa43270e: 0x00000000000c5db8: /lib64/libglib-2.0.so.0 + 0x3270e
(g_main_context_iteration + 0x6e)
0x00002aaaaf5a2119: 0x0000000000058608:
/usr/lib64/openoffice.org/program/libvclplug_gtk680lx.so + 0x22119
(GtkXLib::Yield(bool, bool) + 0xe9)
0x00000033037548de: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x1548de
(Application::Yield(bool) + 0x3e)
0x00000033037549b7: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x1549b7
(Application::Execute() + 0x27)
0x0000000000427a70: 0x0000000000055038:
/usr/lib64/openoffice.org/program/soffice.bin + 0x27a70
(desktop::Desktop::Main() + 0x1250)
0x000000330375a1d4: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x15a1d4 (ImplSVMain() + 0x144)
0x000000330375a2c5: 0x0000000000432428:
/usr/lib64/openoffice.org/program/libvcl680lx.so + 0x15a2c5 (SVMain() + 0x25)
0x000000000041ab68: 0x0000000000055038:
/usr/lib64/openoffice.org/program/soffice.bin + 0x1ab68 (main + 0xa8)
0x00000032f901e074: 0x000000000014fb60: /lib64/libc.so.6 + 0x1e074
(__libc_start_main + 0xf4)
0x000000000041aa09: 0x0000000000055038:
/usr/lib64/openoffice.org/program/soffice.bin + 0x1aa09
(Window::SetPosSizePixel(long, long, long, long, unsigned short) + 0x379)
...end stackreport details ...
...start sample ldd details ...
	linux-vdso.so.1 =>  (0x00007fff74dfe000)
	libgtk-x11-2.0.so.0 => /usr/lib64/libgtk-x11-2.0.so.0 (0x00002aaaaad2c000)
	libgdk-x11-2.0.so.0 => /usr/lib64/libgdk-x11-2.0.so.0 (0x00002aaaab31c000)
	libatk-1.0.so.0 => /usr/lib64/libatk-1.0.so.0 (0x00002aaaab5bc000)
	libgdk_pixbuf-2.0.so.0 => /usr/lib64/libgdk_pixbuf-2.0.so.0 (0x00002aaaab7db000)
	libpangocairo-1.0.so.0 => /usr/lib64/libpangocairo-1.0.so.0 (0x00002aaaab9f8000)
	libpango-1.0.so.0 => /usr/lib64/libpango-1.0.so.0 (0x00002aaaabc02000)
	libcairo.so.2 => /usr/lib64/libcairo.so.2 (0x00002aaaabe44000)
	libgmodule-2.0.so.0 => /lib64/libgmodule-2.0.so.0 (0x00002aaaac0c1000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00002aaaac2c4000)
	libgthread-2.0.so.0 => /lib64/libgthread-2.0.so.0 (0x00002aaaac4c8000)
	librt.so.1 => /lib64/librt.so.1 (0x00002aaaac6cd000)
	libdbus-glib-1.so.2 => /usr/lib64/libdbus-glib-1.so.2 (0x00002aaaac8d6000)
	libdbus-1.so.3 => /lib64/libdbus-1.so.3 (0x00002aaaacaf5000)
	libgobject-2.0.so.0 => /lib64/libgobject-2.0.so.0 (0x00002aaaacd31000)
	libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 (0x00002aaaacf71000)
	libvclplug_gen680lx.so =>
/usr/lib64/openoffice.org/program/libvclplug_gen680lx.so (0x00002aaaad238000)
	libvcl680lx.so => /usr/lib64/openoffice.org/program/libvcl680lx.so
(0x00002aaaad4d6000)
	libpsp680lx.so => /usr/lib64/openoffice.org/program/libpsp680lx.so
(0x00002aaaadb19000)
	libsot680lx.so => /usr/lib64/openoffice.org/program/libsot680lx.so
(0x00002aaaade09000)
	libutl680lx.so => /usr/lib64/openoffice.org/program/libutl680lx.so
(0x00002aaaae084000)
	libtl680lx.so => /usr/lib64/openoffice.org/program/libtl680lx.so
(0x00002aaaae347000)
	libcomphelp4gcc3.so => /usr/lib64/openoffice.org/program/libcomphelp4gcc3.so
(0x00002aaaae5fd000)
	libucbhelper4gcc3.so => /usr/lib64/openoffice.org/program/libucbhelper4gcc3.so
(0x00002aaaae979000)
	libuno_cppuhelpergcc3.so.3 =>
/usr/lib64/openoffice.org/program/libuno_cppuhelpergcc3.so.3 (0x00002aaaaec09000)
	libuno_cppu.so.3 => /usr/lib64/openoffice.org/program/libuno_cppu.so.3
(0x00002aaaaeeca000)
	libvos3gcc3.so => /usr/lib64/openoffice.org/program/libvos3gcc3.so
(0x00002aaaaf0f9000)
	libuno_sal.so.3 => /usr/lib64/openoffice.org/program/libuno_sal.so.3
(0x00002aaaaf320000)
	libX11.so.6 => /usr/lib64/libX11.so.6 (0x00002aaaaf717000)
	libXext.so.6 => /usr/lib64/libXext.so.6 (0x00002aaaafa1c000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00002aaaafc2d000)
	libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x00002aaaafe48000)
	libm.so.6 => /lib64/libm.so.6 (0x00002aaab0149000)
	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00002aaab03cc000)
	libc.so.6 => /lib64/libc.so.6 (0x00002aaab05da000)
	libXfixes.so.3 => /usr/lib64/libXfixes.so.3 (0x00002aaab0931000)
	libpng12.so.0 => /usr/lib64/libpng12.so.0 (0x00002aaab0b36000)
	libfontconfig.so.1 => /usr/lib64/libfontconfig.so.1 (0x00002aaab0d5a000)
	libXrender.so.1 => /usr/lib64/libXrender.so.1 (0x00002aaab0f8f000)
	libXinerama.so.1 => /usr/lib64/libXinerama.so.1 (0x00002aaab1198000)
	libXi.so.6 => /usr/lib64/libXi.so.6 (0x00002aaab139a000)
	libXrandr.so.2 => /usr/lib64/libXrandr.so.2 (0x00002aaab15a4000)
	libXcursor.so.1 => /usr/lib64/libXcursor.so.1 (0x00002aaab17ab000)
	libpangoft2-1.0.so.0 => /usr/lib64/libpangoft2-1.0.so.0 (0x00002aaab19b5000)
	libfreetype.so.6 => /usr/lib64/libfreetype.so.6 (0x00002aaab1be6000)
	libz.so.1 => /lib64/libz.so.1 (0x00002aaab1e75000)
	/lib64/ld-linux-x86-64.so.2 (0x00000032f7e00000)
	libnsl.so.1 => /lib64/libnsl.so.1 (0x00002aaab208a000)
	libcap.so.1 => /lib64/libcap.so.1 (0x00002aaab22a2000)
	libSM.so.6 => /usr/lib64/libSM.so.6 (0x00002aaab24a6000)
	libICE.so.6 => /usr/lib64/libICE.so.6 (0x00002aaab26b0000)
	libi18nisolang1gcc3.so =>
/usr/lib64/openoffice.org/program/libi18nisolang1gcc3.so (0x00002aaab28cc000)
	libbasegfx680lx.so => /usr/lib64/openoffice.org/program/libbasegfx680lx.so
(0x00002aaab2ad2000)
	libicuuc.so.38 => /usr/lib64/libicuuc.so.38 (0x00002aaab2d3e000)
	libicule.so.38 => /usr/lib64/libicule.so.38 (0x00002aaab3076000)
	libjvmaccessgcc3.so.3 =>
/usr/lib64/openoffice.org/program/libjvmaccessgcc3.so.3 (0x00002aaab32ac000)
	libjvmfwk.so.3 => /usr/lib64/openoffice.org/program/libjvmfwk.so.3
(0x00002aaab34b4000)
	libuno_salhelpergcc3.so.3 =>
/usr/lib64/openoffice.org/program/libuno_salhelpergcc3.so.3 (0x00002aaab36d0000)
	libcrypt.so.1 => /lib64/libcrypt.so.1 (0x00002aaab38d4000)
	libxcb-xlib.so.0 => /usr/lib64/libxcb-xlib.so.0 (0x00002aaab3b0d000)
	libxcb.so.1 => /usr/lib64/libxcb.so.1 (0x00002aaab3d0e000)
	libXau.so.6 => /usr/lib64/libXau.so.6 (0x00002aaab3f28000)
	libexpat.so.1 => /lib64/libexpat.so.1 (0x00002aaab412b000)
	libicudata.so.38 => /usr/lib64/libicudata.so.38 (0x00002aaab434e000)
	libxml2.so.2 => /usr/lib64/libxml2.so.2 (0x00002aaab4ff8000)
	libXdmcp.so.6 => /usr/lib64/libXdmcp.so.6 (0x00002aaab5337000)
...end sample ldd details ...
Comment 1 michael.ruess 2007-10-15 09:15:30 UTC
As it looks, you work with the OOo build provided by Fedora. With the native OOo
build, this does not happen. Please refer to Fedora's support, because they
compile their own builds.
Comment 2 michael.ruess 2007-10-15 09:16:08 UTC
Closed.
Comment 3 caolanm 2007-10-16 08:34:17 UTC
"/usr/lib64/xorg/modules//drivers/nvidia_drv.so" is probably the problem, this
looks like https://bugzilla.redhat.com/show_bug.cgi?id=299681 which has the same
crash where  "upgrading to 100.14.19 [version of nvidia driver] fixed the issue."
Comment 4 caolanm 2007-10-19 09:15:02 UTC
got some more insight into this
Comment 5 caolanm 2007-10-19 09:15:53 UTC
its the gtk theme, e.g. thinice has this problem
Comment 6 caolanm 2007-10-19 09:16:28 UTC
*** Issue 79711 has been marked as a duplicate of this issue. ***
Comment 7 caolanm 2007-10-19 09:46:04 UTC
Grr..., same problem as https://bugzilla.mozilla.org/show_bug.cgi?id=389801 I
believe
Comment 8 caolanm 2007-10-19 09:50:17 UTC
Created attachment 49023 [details]
patch to fix
Comment 9 caolanm 2007-10-19 09:51:28 UTC
cmc->pl: Can be reproduced by changing the theme in gnome to e.g. ThinIce for
controls.
Comment 10 caolanm 2007-10-19 10:31:58 UTC
*** Issue 82078 has been marked as a duplicate of this issue. ***
Comment 11 philipp.lohmann 2007-10-19 11:45:56 UTC
good catch, thank you.

committed in CWS vcl83
Comment 12 philipp.lohmann 2007-10-19 11:58:45 UTC
oops, sorry wrong target. Will create another 2.3.1 CWS.
Comment 13 philipp.lohmann 2007-10-19 13:39:25 UTC
fixed in CWS vcl23102
Comment 14 philipp.lohmann 2007-10-19 14:18:46 UTC
adusting prio
Comment 15 philipp.lohmann 2007-10-19 18:37:20 UTC
please verify in CWS vcl23102
Comment 16 stefan.baltzer 2007-10-22 10:58:49 UTC
SBA->PL: As seen, this problem does NOT occur "as reliable" as expected. Thus
the target OOo 2.3.1 is not justified. Reopening issue, Set target to OOo 2.4.
Comment 17 stefan.baltzer 2007-10-22 11:00:57 UTC
SBA: Reassigned to PL.
Comment 18 philipp.lohmann 2007-10-22 11:08:21 UTC
so added issue back to CWS vcl83 then.
Comment 19 rene 2007-10-22 12:18:29 UTC
sba: you *did* test with an up-to-date Gtk, didn't you? (>= 2.12). The problem 
seems to appear only with this and the bug didn't show up before...
Comment 20 philipp.lohmann 2007-10-22 12:32:17 UTC
No, and why should he, when nobody ever mentioned that was the case ? For me, my
ubuntu aptitude says gtk2.0-2.8.20. And I couldn't reproduce the problem either;
however I assumed that the problem occured on x86_64 only.
Comment 21 rene 2007-10-22 12:48:41 UTC
pl: then I now tell you that you should test with 2.12 :) The first reports of 
this (like http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=444741) came in 
after gtk 2.12 was uploaded).
pl: counter-question: why should he try with an ancient one?

Note that the development versions of Debian and the latest Ubuntu release 
already contain that Gtk. Fedora has it, too.

Fixing "Platform".

FWIW, I still think we should fix this for 2.3.1.
Comment 22 philipp.lohmann 2007-10-22 13:03:46 UTC
Another counter question: why should anyone do nothing the whole day but
installing the latest and greatest Linux xyz distribution ? We're not
maintainers of debian, fedora, suse, yellowdog, turbolinux, ubuntu, kanotix, or
laberschwaetzix. If the report says, this is happening on gtk ThinIce, then I
expect this to happen on gtk ThinIce, not on "it happens to happen on my latest
bleeding edge distribution".
Comment 23 philipp.lohmann 2007-10-22 13:04:36 UTC
pl->sba: so, does the fact that the latest Ubuntu should show this problem
change the target back ?
Comment 24 rene 2007-10-22 13:46:02 UTC
pl: I agree with you, but not testing with anything recent but only with 
someting old is not exactly that helpful either.

The Gtk version is not mentioned in the initial post because the submitter 
didn't think it might be a gtk problem. Caolan probably just fixed it and
didn't look at Gtk either. And wrt, x86_64, well, that was set wrongly by the 
submitter, too, but submitters often make such small errors when reporting 
bugs.
That was why I asked specifically about 2.12 because I know that appeared with 
2.12.

See mrus closing. If no one jumped into this this would have been stayed 
closed, wouldn't it? Even though it will happen on up-to-date systems and
(most probably) also on vanilla OOos...
Comment 25 philipp.lohmann 2007-10-22 15:41:33 UTC
"There and back again" - a developer's tale by pl

so again, fixed in CWS vcl23102, rebuilding install sets.
Comment 26 philipp.lohmann 2007-10-22 17:57:43 UTC
pl->sba: "same procedure as every year, james" :-) please verify in CWS vcl23102
Comment 27 stefan.baltzer 2007-10-23 17:05:45 UTC
SBA: Verified in CWS vcl23102.
Comment 28 uberpinguin 2007-11-01 04:03:30 UTC
This patch seems to fix the issue for some dialogs, but I am still running into
several (such as the Open File dialog and the View option in Preferences) that
crash when using GTK themes based on the pixmap engine.
I looked through the OOG680_m7 tarball, and I don't see any other g_free
pIndicator*, so I'm not sure where else this could be failing.  I'll try
rebuilding with debugging symbols, but won't be able to report more for another
8.5+ hours while it compiles.
Comment 29 uberpinguin 2007-11-02 04:12:07 UTC
There was a mistake in my patch/build process.  This patch does fix the issue
after all.
Comment 30 frank 2007-11-14 10:51:32 UTC
*** Issue 83579 has been marked as a duplicate of this issue. ***
Comment 31 frank 2007-11-19 08:48:07 UTC
*** Issue 83745 has been marked as a duplicate of this issue. ***
Comment 32 philipp.lohmann 2007-11-23 12:30:15 UTC
*** Issue 83682 has been marked as a duplicate of this issue. ***
Comment 33 philipp.lohmann 2008-01-07 10:25:56 UTC
*** Issue 83737 has been marked as a duplicate of this issue. ***
Comment 34 stefan.baltzer 2008-03-13 17:18:43 UTC
Still OK in OOo 2.4. Closed.