Issue 84487 - Dialog width unexpectedly increments itself
Summary: Dialog width unexpectedly increments itself
Alias: None
Product: App Dev
Classification: Unclassified
Component: scripting (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: ab
QA Contact: Unknown
Keywords: regression
: 86630 (view as issue list)
Depends on:
Reported: 2007-12-12 11:39 UTC by silvercapo
Modified: 2017-05-20 09:31 UTC (History)
7 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

patch (2.00 KB, patch)
2008-03-03 06:51 UTC, Frank Schönheit
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description silvercapo 2007-12-12 11:39:37 UTC
On OOo 2.3.1 release (not RC1) running on WinXP, in the Dialog Editor when
editing a dialog, found that if you change any of the positional / dimensional
properties of the dialog (height, width, positionX, positionY), the width
automatically and unexpectly increments itself by 3. (This doesn't happen if you
change any of the other non-positional/dimensional properties)

1. Open any OOo application, and bring up the Basic IDE, and insert a new dialog
2. Double-click on the edge of the dialog window being designed to bring up its
properties ("Properties: Dialog") window
3. Type in any new numeric value for any of "Height", "Width", "PositionX", or
"PositionY". (You will need to navigate click outside the textbox for the new
value to be accepted, such that the dialog shown is refreshed/resized)
4. Observe that Width now also increments by 3 automatically.

By manually setting the width to be 3 pixels less than what you need after
editing any positional/dimensional properties.
Comment 1 kay.ramme 2007-12-18 13:47:07 UTC
->Andreas, are you maintaining the Dialog editor?
Comment 2 ab 2007-12-21 13:08:49 UTC
I could reproduce this problem. STARTED, OOo 3.x
Comment 3 Frank Schönheit 2008-03-03 06:51:09 UTC
This is a regression of the fix for issue 78648, which implemented a change that
when the DialogControl is resized, the new size is forwarded to the
DialogControlModel. Unfortunately, the change forgot to take into account the
decoration of the dialog (title bar, border width), which adds to the control's
size, but must *not* add to the model's size.

Will attach a patch.
Comment 4 Frank Schönheit 2008-03-03 06:51:41 UTC
Created attachment 51857 [details]
Comment 5 Frank Schönheit 2008-03-03 06:53:08 UTC
fs->ab: you never were serious with the 3.x target for such an essential
functionality, were you? ;-)

Changing issue type to PATCH, targeting to 3.0.
Comment 6 mikhail.voytenko 2008-03-03 07:23:51 UTC
Adding zhangxiaofei in CC.
Comment 7 Frank Schönheit 2008-03-03 12:27:51 UTC
*** Issue 86630 has been marked as a duplicate of this issue. ***
Comment 8 Ariel Constenla-Haile 2008-03-03 13:46:01 UTC
added myself to cc
Comment 9 Ariel Constenla-Haile 2008-03-03 22:36:34 UTC
For the sake of completeness, and as the release meeting

declared this issue "not confirmed as stopper as it is already in 2.3.1", the
issue in the way it is present in 2.4.0 RC2 is *NOT* the same as in 2.3.1:

as the user reporting this says, in 2.3.1 there is a *workaround*: decrease by 3
will result in the expected size.

But in 2.4.0 RC2 it is impossible to set the size in the dialog editor even with
this workaround: if you change the Height, it changes the Width; if you try to
fix the Width, it will change the Height,... and so on... 

In 2.4.0 RC2 the only workaround is to edit the XML file, what obviously is no
workaround at all.
Comment 10 Frank Schönheit 2008-03-04 15:09:17 UTC
grabbing for committing the fix into a 2.4-CWS (has just been approved by
release meeting)
Comment 11 Frank Schönheit 2008-03-04 15:12:21 UTC
patch committed to CWS dlgedresizing
Comment 12 Frank Schönheit 2008-03-05 08:04:59 UTC
Comment 13 Frank Schönheit 2008-03-05 08:06:17 UTC
fs->jsk: lease verify in CWS dlgedresizing
Comment 14 joerg.skottke 2008-03-05 09:58:57 UTC
Comment 15 joerg.skottke 2008-03-11 15:13:12 UTC
Comment 16 Ariel Constenla-Haile 2008-11-26 13:34:26 UTC
Reopening it: it is back on DEV300_m35
Comment 17 Frank Schönheit 2008-11-26 13:53:41 UTC
sounds like a regression of CWS aw033 to me: This CWS refactored large parts of
the drawing layer, was integrated into m30, and the problem here is present in
m30, but not in m29.

Assigning to the owner of the dialog editor (ab), cc'ing aw (the author of
aw033), targeting to 3.1, adding "regression" keyword.
Comment 18 Frank Schönheit 2008-11-26 13:55:18 UTC
The good news is: The bug is fixed in CWS aw058. Resetting back to FIXED.

@arielch: Could you please try this bug again once m37 is out (this is where
aw058 has been integrated).
Comment 19 Frank Schönheit 2008-11-26 13:55:40 UTC
for the record:
Comment 20 Armin Le Grand 2008-11-26 14:01:07 UTC
AW: aw058 is integrated in DEV300 m36.
Comment 21 Ariel Constenla-Haile 2008-11-26 14:06:38 UTC
-> fs: is there a DEV300_m36? ... 
ha yes! it seems it was added today. So I'll switch my svn copy, build it, and
tell you tomorrow.
Comment 22 Ariel Constenla-Haile 2008-11-27 04:11:15 UTC
-> fs/aw: Yes, this one has disappear in DEV300_m36, but please take a look at