Apache OpenOffice (AOO) Bugzilla – Issue 84487
Dialog width unexpectedly increments itself
Last modified: 2017-05-20 09:31:57 UTC
On OOo 2.3.1 release (not RC1) running on WinXP, in the Dialog Editor when editing a dialog, found that if you change any of the positional / dimensional properties of the dialog (height, width, positionX, positionY), the width automatically and unexpectly increments itself by 3. (This doesn't happen if you change any of the other non-positional/dimensional properties) STEPS TO REPRODUCE THE PROBLEM: 1. Open any OOo application, and bring up the Basic IDE, and insert a new dialog "Dialog1" 2. Double-click on the edge of the dialog window being designed to bring up its properties ("Properties: Dialog") window 3. Type in any new numeric value for any of "Height", "Width", "PositionX", or "PositionY". (You will need to navigate click outside the textbox for the new value to be accepted, such that the dialog shown is refreshed/resized) 4. Observe that Width now also increments by 3 automatically. WORKAROUND By manually setting the width to be 3 pixels less than what you need after editing any positional/dimensional properties.
->Andreas, are you maintaining the Dialog editor?
I could reproduce this problem. STARTED, OOo 3.x
This is a regression of the fix for issue 78648, which implemented a change that when the DialogControl is resized, the new size is forwarded to the DialogControlModel. Unfortunately, the change forgot to take into account the decoration of the dialog (title bar, border width), which adds to the control's size, but must *not* add to the model's size. Will attach a patch.
Created attachment 51857 [details] patch
fs->ab: you never were serious with the 3.x target for such an essential functionality, were you? ;-) Changing issue type to PATCH, targeting to 3.0.
Adding zhangxiaofei in CC.
*** Issue 86630 has been marked as a duplicate of this issue. ***
added myself to cc
For the sake of completeness, and as the release meeting http://wiki.services.openoffice.org/wiki/ReleaseStatus_Minutes#2008-03-03 declared this issue "not confirmed as stopper as it is already in 2.3.1", the issue in the way it is present in 2.4.0 RC2 is *NOT* the same as in 2.3.1: as the user reporting this says, in 2.3.1 there is a *workaround*: decrease by 3 will result in the expected size. But in 2.4.0 RC2 it is impossible to set the size in the dialog editor even with this workaround: if you change the Height, it changes the Width; if you try to fix the Width, it will change the Height,... and so on... In 2.4.0 RC2 the only workaround is to edit the XML file, what obviously is no workaround at all.
grabbing for committing the fix into a 2.4-CWS (has just been approved by release meeting)
patch committed to CWS dlgedresizing
fixed
fs->jsk: lease verify in CWS dlgedresizing
Verified
close
Reopening it: it is back on DEV300_m35
sounds like a regression of CWS aw033 to me: This CWS refactored large parts of the drawing layer, was integrated into m30, and the problem here is present in m30, but not in m29. Assigning to the owner of the dialog editor (ab), cc'ing aw (the author of aw033), targeting to 3.1, adding "regression" keyword.
The good news is: The bug is fixed in CWS aw058. Resetting back to FIXED. @arielch: Could you please try this bug again once m37 is out (this is where aw058 has been integrated).
for the record: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Faw058
AW: aw058 is integrated in DEV300 m36.
-> fs: is there a DEV300_m36? ...http://svn.services.openoffice.org/ooo/tags/ ha yes! it seems it was added today. So I'll switch my svn copy, build it, and tell you tomorrow.
-> fs/aw: Yes, this one has disappear in DEV300_m36, but please take a look at http://www.openoffice.org/issues/show_bug.cgi?id=96642