Issue 89030 - Rename Slide crashes OOo - integrated
Summary: Rename Slide crashes OOo - integrated
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: editing (show other issues)
Version: BEA300m1
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords: crash, oooqa
Depends on:
Blocks: 87736
  Show dependency tree
 
Reported: 2008-05-05 17:18 UTC by Rainer Bielefeld
Modified: 2008-06-25 15:48 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Rainer Bielefeld 2008-05-05 17:18:58 UTC 
'Rename Slide' crashes OOo.

Steps to reproduce:

1. Start OOo
2. Open new DRAWing
3. Rightclick on "Slide 1" in 'Page Pane'
4. Context menu 'New Page'
5.  Rightclick on "Slide 2" in 'Page Pane'
6. Context menu 'Rename Page'
7. Insert new name "xxxxx" into appearing dialogue box and confirm with <ok>
   expected: Slide will be renamed to "xxxxx"
   actual: crash

Rename will be successful after crash recovery.

I will contribute crash report ID asap.
Comment 1 cno 2008-05-05 17:32:39 UTC 
Does not crash for me BEA300m2 (build 9301)
Also on XP.
Comment 2 andreschnabel 2008-05-05 21:16:01 UTC 
confirmed on WinXP and Linux.

OOo crashes, if a slide gets renamed, right after it has been inserted.
Comment 3 Rainer Bielefeld 2008-05-06 06:12:44 UTC 
I checked with [300m2 (Build9301)]" and still see the crash.
Comment 4 cno 2008-05-06 07:57:35 UTC 
@ Rainer: I clicked on another slide first, before renaming #2.
Also when (in the slides pane) rightclick on the new slide first, leftclick on
the new slide, then rightclick and rename, the office does not crash.
But renaming direct with rightclick, does crash indeed.
Comment 5 cno 2008-05-06 08:00:32 UTC 
btw: I have the same crash in Impress...
and also when the slide is inserted via the menu.
Comment 6 wolframgarten 2008-05-06 09:16:43 UTC 
Reproducible. Reassigned. Also happening in DEV300m11.
Comment 7 wolframgarten 2008-05-06 09:18:43 UTC 
Ok in OOo 2.4.
Comment 8 Rainer Bielefeld 2008-05-07 11:10:46 UTC 
Crash report IDs are rgdgtt, rnw5tt, rx8jtt, rqnjtt.
I hope they are all related to this issue, because of the very late response
it's really difficult to keep track of the error reports.
Comment 9 groucho266 2008-05-07 13:03:04 UTC 
The crash occurs in sd::slidesorter::SlotManager::RenameSlideFromDrawViewShell()
when there is no current page.  This is caused by the current page pointer not
properly updated when sd::slidesorter::CurrentSlideManager::HandleModelChange()
is called (e.g. in this case when the new slide is inserted).

Fixed at both places:
Avoid the crash in RenameSlideFromDrawViewShell by handling a NULL pointer.
HandleModelChange() now correctly updates the current slide pointer.

Modified files:
/sd/source/ui/slidesorter/controller/SlsCurrentSlideManager.cxx    rev. 1.3.18.1
/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx    rev. 1.33.18.1
Comment 10 groucho266 2008-05-08 10:12:49 UTC 
Please verify.
Comment 11 christian.guenther 2008-05-14 16:46:13 UTC 
CGU: Verified in cws impress142
Comment 12 christian.guenther 2008-06-24 18:15:59 UTC 
CGU: integrated in dev300m19
Comment 13 uwe.luebbers 2008-06-25 15:48:00 UTC 
added "integrated" to the title